----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review69749 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java <https://reviews.apache.org/r/30250/#comment114551> I also think one SessionClosed event is enough. Main motivation behind these events is to allow other services to manage per session resources. From that perspective SessionExpired and SessionClosed are the same. lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java <https://reviews.apache.org/r/30250/#comment114552> @Raju, Instead of this unit test, we should check if the events are getting generated when sessions are closed/opened. We already have a TestSessionResource. Can we add few testcases for events there? What we are testing here is essentially just event send and receive, that has been already verified in other test cases in this class. - Jaideep dhok On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 8:56 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c95a948 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > 0db5c02 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
