> On Jan. 30, 2015, 10:04 a.m., Amareshwari Sriramadasu wrote: > > checkstyle/src/main/resources/checkstyle.xml, line 228 > > <https://reviews.apache.org/r/30447/diff/1/?file=841418#file841418line228> > > > > Why are we removing this?
Reverted the file. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30447/#review70340 ----------------------------------------------------------- On Jan. 30, 2015, 9:40 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30447/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 9:40 a.m.) > > > Review request for lens. > > > Bugs: LENS-245 > https://issues.apache.org/jira/browse/LENS-245 > > > Repository: lens > > > Description > ------- > > checkstyle fixed for lens ml lib > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml > e519a60fca323cfaaeec6a675969a7f490330778 > lens-ml-lib/pom.xml 4f6aaa8f406ebcfe108fe7aed082b22bd53933a2 > lens-ml-lib/src/main/java/org/apache/lens/api/ml/ModelMetadata.java > 3fcb3f69be356c2f86384c473d6136dfa83ac0d1 > lens-ml-lib/src/main/java/org/apache/lens/api/ml/TestReport.java > 4c0bf5176a985869beba07fde488bf3e5a2ed0b1 > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java > 5c5bc65e3a13df9d77938af4d3ee41cb80e33018 > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java > 0cc182477f91b0fff7925e334e8585f9017edaf2 > lens-ml-lib/src/main/java/org/apache/lens/ml/Algorithms.java > ffe4bfcf70699aa76f435fd9e691d26b5c4f87ee > lens-ml-lib/src/main/java/org/apache/lens/ml/ClassifierBaseModel.java > 46f69309476f8185e8f632101d6012157ebdc9e3 > lens-ml-lib/src/main/java/org/apache/lens/ml/ExampleUtils.java > 8ca2b7a897e540c45aa254705c138eaa9ab04a6a > lens-ml-lib/src/main/java/org/apache/lens/ml/ForecastingModel.java > 24acc3af9b2f8c2830c96c0fba38dade511f5961 > lens-ml-lib/src/main/java/org/apache/lens/ml/HiveMLUDF.java > 30e253d6c7d671d272d68ef8edac4595354cc5df > lens-ml-lib/src/main/java/org/apache/lens/ml/LabelledPrediction.java > 043e56115bbddc5c55b6f5570955f53e473506cf > lens-ml-lib/src/main/java/org/apache/lens/ml/LensML.java > a09a93fc0a1446134cbb6da4e0f8e322e86b3a75 > lens-ml-lib/src/main/java/org/apache/lens/ml/LensMLImpl.java > 2233a8c6f9f45c8db446df0f4b31547ecb0c44a6 > lens-ml-lib/src/main/java/org/apache/lens/ml/MLDriver.java > 1a9877c0844fed84ef6e609f923beabe8bca5fd8 > lens-ml-lib/src/main/java/org/apache/lens/ml/MLModel.java > a9ba0fa24f7d5a02c3d8759f6f205dc8043a1fb4 > lens-ml-lib/src/main/java/org/apache/lens/ml/MLTestMetric.java > 3743e426aad467e19df0f885fb00de0bb450a672 > lens-ml-lib/src/main/java/org/apache/lens/ml/MLTestReport.java > 0c70a8c46cdc618585475fdd3bc0bce9118b9b6d > lens-ml-lib/src/main/java/org/apache/lens/ml/MLTrainer.java > 40dc01409dfe8b7231e4d85a5099507c30bd902c > lens-ml-lib/src/main/java/org/apache/lens/ml/MLUtils.java > ce21d2468664d22e44c00c3d8be0a7be0facb84e > lens-ml-lib/src/main/java/org/apache/lens/ml/ModelLoader.java > 6c6d13a178fb7469953288dadfce0c9e316189a9 > lens-ml-lib/src/main/java/org/apache/lens/ml/MultiPrediction.java > c6ebfff8f796c6d7d41f1b90a2d2857396b19341 > lens-ml-lib/src/main/java/org/apache/lens/ml/TableTestingSpec.java > e73e98948ea747a48e50fa171cadf32650af092d > lens-ml-lib/src/main/java/org/apache/lens/ml/TestQueryRunner.java > 6f8d597ffdc9748325cc398c37e06a75e2d7d435 > lens-ml-lib/src/main/java/org/apache/lens/ml/TrainerArgParser.java > 0461767f1ee5eceaba66bec52242d284271fdffa > lens-ml-lib/src/main/java/org/apache/lens/ml/dao/MLDBUtils.java > 4aecae4f0fe4ebf9e1ecddbbf9536fc751df29c0 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/ColumnFeatureFunction.java > 0a9fa09de3cb846341671743222011b68b46425c > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/DoubleValueMapper.java > f6a2c0bd723d0db64f86cc067a9d6595a2e4e94b > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/FeatureFunction.java > 95e4ba8cc0d993cbdcd4e18b62e718b83b93d402 > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/FeatureValueMapper.java > 5e55a05031d223a63194135c3ba1eb5eaa1a0539 > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/HiveTableRDD.java > fc4456da5c9eea412b92b8f71764c8c2667db695 > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/SparkMLDriver.java > 951cf67838b6801395c9f34316ee01f46ecb5f42 > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/TableTrainingSpec.java > 7be4c0812818d477a1f8ded798415390dc0bbc64 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/BaseSparkClassificationModel.java > 7a126492e43910bc7fd9a4c8b211dd589f02c604 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/DecisionTreeClassificationModel.java > 57d90fb64c51d44374f35aa7f6a9594df6c2211a > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/KMeansClusteringModel.java > 0d2ba7016fc7354d0e5735a060ad0c563a7e3981 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/LogitRegressionClassificationModel.java > 08a788c505fe3b7d769da269eb33f370a48318d8 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/NaiveBayesClassificationModel.java > 27a1f38f9320691f673dc4d910b04b81aa65f9ed > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/SVMClassificationModel.java > df885b36d811001398b3842e0edbce5f43e152a7 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/models/SparkDecisionTreeModel.java > 5211f457c90a191a1caade5917075288c1c6d6b8 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/BaseSparkTrainer.java > 115fef343bfeda4590d134f869b0ba46008aa54e > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/DecisionTreeTrainer.java > 4eea13199db2e658ddc5daf4a6111d4e008b6519 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/KMeansTrainer.java > c2230521d0b32e0f7d7293b39c394a10e7eae62e > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/LogisticRegressionTrainer.java > 169df4202da94c7021ac072c4af712dd42ff5a48 > > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/NaiveBayesTrainer.java > d34409c3a77fba4b7356b9c0359683ff16320539 > lens-ml-lib/src/main/java/org/apache/lens/ml/spark/trainers/SVMTrainer.java > 9e42f5535b224dcf77a5f4c06fc488b7a2d08088 > lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java > d2bed0a77e6566ed7f7f610c14b7a394479395bd > > lens-ml-lib/src/main/java/org/apache/lens/rdd/HCatRecordToObjectListMapper.java > 6e587809ddac049473b087b4d6227bae2fe50ca2 > lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java > e513c556e5f4f400ef09ad26053426d07801d59f > lens-ml-lib/src/main/java/org/apache/lens/server/ml/MLServiceImpl.java > be7cd27940fb86e3527f573e58c754e1c265b72b > lens-ml-lib/src/main/java/org/apache/lens/server/ml/MLServiceResource.java > 08fc64ba0db379661068a0943e9f69a00a21d993 > lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java > d1318fc76cc7a8c13abfee51c0095c3f8865c5cf > lens-ml-lib/src/test/resources/lens-site.xml > 01f2dddb58021dbb325a016b640c9fe8d9d0b505 > lens-ml-lib/testutils/hadoop 415561fbcf9a6b64732ac84d62b44ce351ad1be3 > > Diff: https://reviews.apache.org/r/30447/diff/ > > > Testing > ------- > > build succeeds. > > > Thanks, > > Rajat Khandelwal > >
