-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30449/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-248
    https://issues.apache.org/jira/browse/LENS-248


Repository: lens


Description
-------

removed hive driver checkstyle errors. some jdbc remaining


Diffs
-----

  checkstyle/src/main/resources/checkstyle.xml 
e519a60fca323cfaaeec6a675969a7f490330778 
  lens-driver-hive/pom.xml 17d411885d38887dbf93027099d11dc83619b21c 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java
 634ec5676173a003917c8dfbcd31717ef04beb43 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
64bc2816122bc2b3dc48a4dd5865ce25b34e4f72 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
 97e9fca08cfd9126dfd47f13312953a55f7f8a04 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java
 9db4538d26fa46fbf63445a91b7c62adee7032d2 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java 
4bda55d95df9407ff130fcc4cc4c36946c702021 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveResultSetMetadata.java
 eb42f3a8470e434ed6932452b7ae0815c2ad85d2 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
 6cf5950564d1fe3f0ee72523255f1b1e9c657927 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java
 282c6c1e5e15a3bc968092db0c8ceb32bbc6b54a 
  
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java
 91e67df12e1c8e89fa5ab6efdc7373e2c63e2f71 
  lens-driver-hive/src/main/resources/hivedriver-default.xml 
11e7210df90ab34d5e5d2bc19793b22cf35a50f5 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
c63a2565a82b1f594c9a9031aea07c06acf8440d 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 26202d7e99309b8626c7be843f230a044b54aa16 
  lens-driver-hive/src/test/resources/hive-site.xml 
116bf1155934e14bfadb8f44ff3a653f555e1304 
  lens-driver-hive/src/test/resources/hivedriver-site.xml 
30e64b17c4f72027a37f9dc5149b0073bdf1c0d7 
  lens-driver-hive/testng.xml b98d25284a7ddf110f6b01fdbc218da5bbc55f35 
  lens-driver-hive/testutils/hadoop c1658c71da1b90b6be10427761117abd6fe31977 
  lens-driver-jdbc/pom.xml 0f2230937d306dd8700d31eca8aaa9e1300d5683 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 5b7f5193506ab7436a1a59bb6ea2c693fc1c366f 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ConnectionProvider.java
 d27af8d6e1516c1c779a6f92c0a0e1f1b577951b 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 555a4953f1273fa7e84e7bc196cc87daf86151bd 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
1b4982a74cc0876b291b06ae008861a91e02fbb1 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 5c4970e1805a8ca4ffbbbd2402e3ff6a366656cf 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 
590620ff7aa7698249b55c9645565941cf045e93 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
4eacb833909390130115ba6ad7cf7e41e1b8e08b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 5af6ead64132e4587bf1b63ac737068952b16fe6 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
 56d33cb7e718ffe1981f1d8c77f03b1aecf25341 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 
7534d89173b2b32ec22bdf14a9c201023ee599b9 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
e1988d45cd01f752ce1767c4fc7325e3bb5dfe36 
  lens-driver-jdbc/src/test/resources/hive-site.xml 
634c89f87f94f3fe96d2e14f7cfc1f0223a2376c 

Diff: https://reviews.apache.org/r/30449/diff/


Testing
-------

[INFO] Starting audit...
/Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java:22:
 Wrong order for 'org.apache.lens.driver.jdbc.JDBCDriverConfConstants.*' import.
/Users/rajat.khandelwal/Git/grill/lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:38:
 Wrong order for 'org.apache.lens.server.api.driver.*' import.
Audit done.


Thanks,

Rajat Khandelwal

Reply via email to