> On Jan. 29, 2015, 11:19 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, > > line 102 > > <https://reviews.apache.org/r/30390/diff/1/?file=839605#file839605line102> > > > > case sensitive taken care? > > Raju Bairishetti wrote: > Did not get comment here?? > > Rajat Khandelwal wrote: > do we need to do `resource.getType.equalsIgnoreCase(type)`?
All the other available options are in lower case only. So it should be case sensitive. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30390/#review70191 ----------------------------------------------------------- On Jan. 30, 2015, 11:34 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30390/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 11:34 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-19 > https://issues.apache.org/jira/browse/LENS-19 > > > Repository: lens > > > Description > ------- > > Provide an option to list all resources added in a session > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > f1b4ea7 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > c8d0383 > lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > bc07e68 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > aa65e15 > lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > b3cf2c3 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 109b36d > src/site/apt/user/cli.apt 270265c > > Diff: https://reviews.apache.org/r/30390/diff/ > > > Testing > ------- > > Added a unit test in TestLensConnectionCliCommands and testing th behavior in > TestSessionResource > > > Thanks, > > Raju Bairishetti > >
