-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30483/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 8:01 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
remove lens-client-site.xml from lens client test resources and change port
number in lenc cli lens-client-site.xml in test resources
Bugs: LENS-83
https://issues.apache.org/jira/browse/LENS-83
Repository: lens
Description
-------
C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r "getTestPort" * | grep -v
class | wc -l
16
Right now, 16 tests are using on some fixed port number. This would be a
problem in future if user wants to add a new test case. User has to know all
the 16 ports which are already occupied by test cases.
Fix: Tests Should use free/available port instead of using fixed/static port.
Changes include:
Creating a socket for getting the free/avaialble port.
C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r " getTestPort(" * | grep
-v class | grep -v patch | wc -l
4
After this change still three tests are using fixed port.
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java
c50aebc
lens-cli/src/test/resources/lens-client-site.xml a837752
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java
f42e992
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 804fe56
lens-client/src/test/resources/lens-client-site.xml a837752
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 19a1a69
lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java
8dc32ac
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java
fc06e71
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 398ce7b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java
0e81abb
lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java
4372a6f
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java
fc32e5b
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
8bf9f81
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java
7ff1aa4
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
aad572e
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
88f16db
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
109b36d
src/site/apt/user/client-config.apt b482108
Diff: https://reviews.apache.org/r/30483/diff/
Testing
-------
All the existing tests are passing with the changes. No new tests are added.
Thanks,
Raju Bairishetti
