----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30497/#review70566 -----------------------------------------------------------
checkstyle/src/main/resources/checkstyle.xml <https://reviews.apache.org/r/30497/#comment115785> Need to add suspend utility constructor facility. Here Credentials is not a utility class. checkstyle module is wrongly assuming it to be one. So in that I've suspended checkstyle. - Rajat Khandelwal On Feb. 2, 2015, 1:52 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30497/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 1:52 p.m.) > > > Review request for lens. > > > Bugs: LENS-247 > https://issues.apache.org/jira/browse/LENS-247 > > > Repository: lens > > > Description > ------- > > cli,client,example,checkstyle > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml > e519a60fca323cfaaeec6a675969a7f490330778 > lens-cli/pom.xml d7e46de7b9dcb1ccc4ebdf20abadfc69aaab10d9 > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 9ae69bd1f7b64229048bbdbf920d77f9ea319e18 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 3b319f15e6b0360d86cff71759f20db5290ed683 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > e9c3904d80658f813441d984d50b0581f9ded3a1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > 30712c45885b3c69ef25d5302587e82504703ab8 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > 201b1ee3a1cadf05c66951892e1a895cf327cb03 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 736df189189b0f9b170d27ce21319078ab484cca > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 51c236572d8e80f7b4be02441425ac37a9f5ebdd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java > 9bfb67d5fbdf8298593923a99d27a1a22c13167f > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 9b07a3b40572519519cf71937add908456c42e55 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 25220ff87ac46a6daf137f3d7be9e3a1a77b7969 > lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java > b98a719596feda48b2189093b362bc27b2383912 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 15cc6bc5068cb87d68e6f6a935da33b12c4e47d1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 2d4d38428f7821e61e29325c3b857cfe990ad2d3 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > f43f53c807d0e726938d3fc3f37fab2adbb021b6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > bb470e16bb444fef362fd85421f1e8d445abd0ee > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > f56cd8b98cacc97c7d9e44620e42c83d6ff47cfe > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 0c302378cbf01cfeae74eeec5c0a6ebb5944015b > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > ed4866fc64c8ce94112c8b1a3d0505fe37650dc9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 834cbfac563455739a6eb4d990ac797d15e8bd39 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 83b5ed4c4c89085604f42181d6571e23b6276547 > lens-client/pom.xml 2a20596611431f43961c2cffce3e42a1f55904ed > lens-client/src/main/java/org/apache/lens/client/Credentials.java > e92783f45420d0c43f5c09a418ed7cf4032d055d > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 3ba70ff1b13d0ac162b7ab0d1cf944a596e9cc96 > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > a4207271e94ee4e1fe9c262082e9eacf51c2b8c1 > lens-client/src/main/java/org/apache/lens/client/LensClientResultSet.java > af0897b4bf8f917a40d87627c80b0d421ed3c679 > > lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java > 9bcd8d5f457e6d3ae9bd37d0eacb99a7374d7ef2 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 32a146a22f0393635a78f616b48c5378f35e81d7 > lens-client/src/main/java/org/apache/lens/client/LensConnectionBuilder.java > 5740e78c2eca3bd5f95e5c7b4fd274ace0369740 > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java > 777a0154d8e36e49f8898795deea29d2f444db61 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > c8dd8eb1b56e881b88d581b4dd901fc03a0d1b2b > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > 085de476c663172a4153a3f8330b121edca1e008 > > lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientException.java > 054801504a28ff62246fd9a019a77def241e76d4 > > lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientServerConnectionException.java > ec5fe7d1dfb88668a77e9b827d482d05529638dc > lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java > 56e861aef1b29ee9941f1c068269303eb22454be > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java > a45d2266cf3cf9eaa289e7cb9df21ace0cadc7dc > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java > beadb0ef6cffb64df0879ff79aedc567e239b8a8 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSet.java > 6828fa435c6e4b1f99963968302a17803743d383 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSetMetadata.java > 68a9fd8a90383fd1ef0ab27ceea097900d8564ec > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcStatement.java > 8a024e93c9b659d2386665fb1d8847d8df27dbb9 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 213e46e91a528184019f836ad5e40d0cdd9f99e4 > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java > 0bde100cdf29d83a4e7782bc31b40086012d85d5 > lens-examples/pom.xml 4fa4f054aefda99028e6c64b88f6f0c39cf38c4e > lens-examples/src/main/java/org/apache/lens/examples/DatabaseUtil.java > 8379ffec774ea80fb4dd3368dd7c6b94c7ad0611 > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 01e83d24ff7f2d49839bc496f6208a5bcf18fd51 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 3dbfb52d8c14f7be5f76048cbcae4f8d3d3053f0 > lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java > 5cea3477e0bf5a175cc12ec7b4e264f952bbb4a0 > lens-examples/src/main/resources/db-storage.xml > 2d105693423be0f5fc88210214a89117a58c375d > lens-examples/src/main/resources/dim1-local-part.xml > 923717d23764ab8df512d5cca53969277a9af690 > lens-examples/src/main/resources/dim2-local-part.xml > b6f727b5e80336fcdeea6cc9e4a09398c251895b > lens-examples/src/main/resources/dim4-local-part.xml > 98c80be73cba3da3ad6b53bd20651ecc5c451c93 > lens-examples/src/main/resources/dim_table.xml > 6b388fd61fd86256f11888ab32f39cbe94d39cd9 > lens-examples/src/main/resources/dim_table2.xml > 4eadfb2581437990b8df2dcd5d237fcb48040aab > lens-examples/src/main/resources/dim_table3.xml > d1177f5e2db0a2ec2f5aac3cc2c0f9a804fbc5d6 > lens-examples/src/main/resources/dim_table4.xml > 14290f6851db87434cd6267e5bab02f120598389 > lens-examples/src/main/resources/fact1-local-part1.xml > 85241464b7c3f9a65a9831635f4cf805891a2989 > lens-examples/src/main/resources/fact1-local-part2.xml > 9799dd723b4d9fe66b378a92c576e9d984ab63de > lens-examples/src/main/resources/fact1-local-part3.xml > 128f3a7a4c5557794de8f5d94b05259797bfbf87 > lens-examples/src/main/resources/fact1.xml > ddcdd5445db6d7e147563f6b06bfcbf8a7b9effe > lens-examples/src/main/resources/fact2-local-part1.xml > a4ce2faa07b40e684e1b4f59b5ad6dccb0893154 > lens-examples/src/main/resources/fact2-local-part2.xml > 308612a60c3df5cefc547f90da7e31943c4bf664 > lens-examples/src/main/resources/fact2-local-part3.xml > 06566a19219c03161510d50ca0ae6fa2cd330a79 > lens-examples/src/main/resources/fact2.xml > 58ad44bf6438c5c41ea69477e5577b0bcbdfa4ec > lens-examples/src/main/resources/local-cluster-storage.xml > 9b10307c151950704d8d6bbd7c41ebb8d2085ef9 > lens-examples/src/main/resources/local-storage.xml > 2b28f5da7e74dcb32d716086ce31cab0384ac56c > lens-examples/src/main/resources/raw-local-part1.xml > faf749e0f586b2a4714a9141adf2d9a6ce89a2d9 > lens-examples/src/main/resources/raw-local-part2.xml > 907007677681c9d52fa168e5f542228a2d33ce7e > lens-examples/src/main/resources/raw-local-part3.xml > b21e9f34dd271fd9063b9b595f85250740c9990d > lens-examples/src/main/resources/raw-local-part4.xml > 037fec2b45407f12ac2e93cb35c290cabcc15c8b > lens-examples/src/main/resources/raw-local-part5.xml > 7b4fdd5f57b385aa374bab52dc9c9d4c7f32118c > lens-examples/src/main/resources/raw-local-part6.xml > b96fb63c73d43b66a0a75f111b410b5960a06d67 > lens-examples/src/main/resources/rawfact.xml > f01e9019267825855cfc81fcd11c4eae894dcb36 > lens-examples/src/main/resources/sample-cube.xml > f89dafc7ce972fab60a5244aeb0fafdd32c70605 > lens-examples/src/main/resources/sample-db-only-dimension.xml > e6d82a7b9a72c29f5d929c8560aac2214ea6c43a > lens-examples/src/main/resources/sample-dimension.xml > 1f7af3c571a23b2e00792031b4c4f8d9c877df3e > lens-examples/src/main/resources/sample-dimension2.xml > fd9a2ca18f19509665746f1b34826a35597d5e9e > > Diff: https://reviews.apache.org/r/30497/diff/ > > > Testing > ------- > > `mvn clean install -Dtest=org.apache.lens.cli.*` passes > > > Thanks, > > Rajat Khandelwal > >
