----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31187/ -----------------------------------------------------------
(Updated Feb. 19, 2015, 1:37 p.m.) Review request for lens, Amareshwari Sriramadasu and Srikanth Sundarrajan. Bugs: LENS-315 https://issues.apache.org/jira/browse/LENS-315 Repository: lens Description ------- Changes - 1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders 2. HiveSessionService starts DatabaseResourceService 3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB Diffs ----- lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578 lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1 lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372 lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION lens-server/testdata/test.jar PRE-CREATION lens-server/testdata/test2.jar PRE-CREATION src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79 Diff: https://reviews.apache.org/r/31187/diff/ Testing (updated) ------- 1. Added unit tests for DatabaseResourceService 2. New unit tests related to class loading Test output [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules ............................. SUCCESS [6.282s] [INFO] Lens .............................................. SUCCESS [10.048s] [INFO] Lens API .......................................... SUCCESS [13.921s] [INFO] Lens API for server and extensions ................ SUCCESS [14.237s] [INFO] Lens Cube ......................................... SUCCESS [9:03.374s] [INFO] Lens DB storage ................................... SUCCESS [16.598s] [INFO] Lens Query Library ................................ SUCCESS [7.817s] [INFO] Lens Hive Driver .................................. SUCCESS [3:45.739s] [INFO] Lens Driver for JDBC .............................. SUCCESS [34.728s] [INFO] Lens Server ....................................... SUCCESS [18:14.639s] [INFO] Lens client ....................................... SUCCESS [51.484s] [INFO] Lens CLI .......................................... SUCCESS [4:07.728s] [INFO] Lens Examples ..................................... SUCCESS [7.675s] [INFO] Lens Distribution ................................. SUCCESS [19.084s] [INFO] Lens ML Lib ....................................... SUCCESS [2:02.433s] [INFO] Lens Regression ................................... SUCCESS [0.703s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 40:17.112s [INFO] Finished at: Thu Feb 19 19:06:08 IST 2015 [INFO] Final Memory: 136M/834M [INFO] ------------------------------------------------------------------------ Thanks, Jaideep dhok