> On March 1, 2015, 7:24 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, > > line 54 > > <https://reviews.apache.org/r/31589/diff/1/?file=881682#file881682line54> > > > > Why is this a class level variable?
If it is classlevel variable. Same conf will used for later queries also. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31589/#review74692 ----------------------------------------------------------- On March 1, 2015, 7:03 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31589/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 7:03 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-370 > https://issues.apache.org/jira/browse/LENS-370 > > > Repository: lens > > > Description > ------- > > Setting queryConf variable in rewriter which is set after every refresh. > Copy class loader of driver into queryConf > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > db653a7154f64fa1343698e501d69dc9dc277950 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 83b956e355d25280a187fe7190300fee757a315d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > c06196054cb550ee89796a31267c60d86187cbb5 > lens-driver-jdbc/testdata/ClassLoaderTestClass.java PRE-CREATION > lens-driver-jdbc/testdata/ClassLoaderTestClass2.java PRE-CREATION > lens-driver-jdbc/testdata/DatabaseJarSerde.java PRE-CREATION > lens-driver-jdbc/testdata/serde.jar PRE-CREATION > lens-driver-jdbc/testdata/test.jar PRE-CREATION > lens-driver-jdbc/testdata/test2.jar PRE-CREATION > lens-driver-jdbc/testdata/testdata2.data PRE-CREATION > > Diff: https://reviews.apache.org/r/31589/diff/ > > > Testing > ------- > > Changed existing unit test to use class with serde in a jar which is added at > runtime. > > > Thanks, > > Jaideep dhok > >
