----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31608/#review74725 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On March 2, 2015, 6:45 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31608/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 6:45 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-364 > https://issues.apache.org/jira/browse/LENS-364 > > > Repository: lens > > > Description > ------- > > 1. Closing session before throwing 404. > 2. Closing session in case db exist check throws exception > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 435eda9d6d38724e7e7ace063d49064a79a1f999 > > Diff: https://reviews.apache.org/r/31608/diff/ > > > Testing > ------- > > Checked log statement in case of invalid DB. > No new test added as test for open session with invalid DB already exists. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.164s] > [INFO] Lens .............................................. SUCCESS [1.846s] > [INFO] Lens API .......................................... SUCCESS [6.339s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.491s] > [INFO] Lens Cube ......................................... SUCCESS [6:02.363s] > [INFO] Lens DB storage ................................... SUCCESS [9.931s] > [INFO] Lens Query Library ................................ SUCCESS [4.566s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:35.589s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [25.349s] > [INFO] Lens Server ....................................... SUCCESS [4:36.297s] > [INFO] Lens client ....................................... SUCCESS [20.175s] > [INFO] Lens CLI .......................................... SUCCESS [1:46.427s] > [INFO] Lens Examples ..................................... SUCCESS [0.800s] > [INFO] Lens Distribution ................................. SUCCESS [9.888s] > [INFO] Lens ML Lib ....................................... SUCCESS [43.146s] > [INFO] Lens Regression ................................... SUCCESS [0.483s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:12.822s > [INFO] Finished at: Mon Mar 02 05:57:08 UTC 2015 > [INFO] Final Memory: 110M/982M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jaideep dhok > >
