-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31154/#review75169
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
<https://reviews.apache.org/r/31154/#comment122145>

    What are we doing here?


- Jaideep dhok


On March 3, 2015, 8:34 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31154/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 8:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-280
>     https://issues.apache.org/jira/browse/LENS-280
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Posting the changes that show the logic change. Not complete yet, it's just 
> so that anyone who wants to look at the new logic can see. 
> 
> cube tests are all passing, remaining things:
> 
> 
> 1. PartitionInfo API, name change and some util methods addition
> 2. Some newly added methods and code belongs in other classes, will move them 
> appropriately.
> 3. Server tests,(TestMetastoreResource)
> 4. javadoc
> 5. will see if some more abstraction can be made, redundancies removed.
> 
> 
> Diffs
> -----
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CaseInsensitiveHashMap.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> d9af602a87cb9d005b0de024750a4d4937888e27 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> b3ed6efd102ed800519ebb9b5d15f81a2a32d5d5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  7e6fe7e93a07ddb6ae4369b78e7856dc2b0a65b5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 979de6d7f1d43f0fb5621e3287f3a6eef3dcdaef 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> c21c72a5ceb0271134423b8a9caf928e524cf150 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionTimeline.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 
> 240516d6911ecdab6a07ef77b194c013aba42f4e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java 
> c4b3c3a4d469f5cc609db67437b00855d907c51d 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
>  b1a85adfb229fa0f6a708a047a7629b2faa28e30 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactPartition.java 
> a60041bf3df0fa03091674b602a78a2323f88d55 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 7eaf597bac879430dff086914865d34102003f0f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 
> 550df6c99b7ffe7372d319b8c4b101cdd5a4f830 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  96ba240404d1f21fbcac572ced0a4e3c911a5731 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 609b7f3a2750a0272f649d4cce3181a0588013e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> 3c960622c4bc7d95bcbd9c66f3f64a8c7eff2cd2 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  4047e0c8b2098929cd6f1d320f7e52db40a280aa 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  9f4595f96354eacabd758053b57183026de116c0 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
>  a0abb0afe3798218f5f4c06d422b5fd36ec628d3 
> 
> Diff: https://reviews.apache.org/r/31154/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.445s]
> [INFO] Lens .............................................. SUCCESS [2.144s]
> [INFO] Lens API .......................................... SUCCESS [6.331s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.346s]
> [INFO] Lens Cube ......................................... SUCCESS [2:19.585s]
> [INFO] Lens DB storage ................................... SUCCESS [9.680s]
> [INFO] Lens Query Library ................................ SUCCESS [4.783s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.169s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.350s]
> [INFO] Lens Server ....................................... SUCCESS [4:35.297s]
> [INFO] Lens client ....................................... SUCCESS [20.677s]
> [INFO] Lens CLI .......................................... SUCCESS [1:51.237s]
> [INFO] Lens Examples ..................................... SUCCESS [0.873s]
> [INFO] Lens Distribution ................................. SUCCESS [9.986s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.241s]
> [INFO] Lens Regression ................................... SUCCESS [0.434s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 13:35.639s
> [INFO] Finished at: Tue Mar 03 08:12:37 UTC 2015
> [INFO] Final Memory: 110M/1305M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to