----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31736/#review75283 -----------------------------------------------------------
Ship it! +1 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/31736/#comment122265> Is selected driver null because no driver is able to answer the query? - Jaideep dhok On March 4, 2015, 6:57 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31736/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 6:57 p.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-293 > https://issues.apache.org/jira/browse/LENS-293 > > > Repository: lens > > > Description > ------- > > Was able to reproduce NPE with testcase added. The patch fixes the NPE. > Created https://issues.apache.org/jira/browse/LENS-387 to send error as part > of QueryHandleWithResultSet structure itself. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 15b9849 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c350d09 > > Diff: https://reviews.apache.org/r/31736/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.707s] > [INFO] Lens .............................................. SUCCESS [3.364s] > [INFO] Lens API .......................................... SUCCESS [9.700s] > [INFO] Lens API for server and extensions ................ SUCCESS [16.299s] > [INFO] Lens Cube ......................................... SUCCESS [6:52.058s] > [INFO] Lens DB storage ................................... SUCCESS [10.503s] > [INFO] Lens Query Library ................................ SUCCESS [5.132s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:31.883s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [25.434s] > [INFO] Lens Server ....................................... SUCCESS [4:33.140s] > [INFO] Lens client ....................................... SUCCESS [20.744s] > [INFO] Lens CLI .......................................... SUCCESS [1:51.203s] > [INFO] Lens Examples ..................................... SUCCESS [0.815s] > [INFO] Lens Distribution ................................. SUCCESS [9.017s] > [INFO] Lens ML Lib ....................................... SUCCESS [42.788s] > [INFO] Lens Regression ................................... SUCCESS [0.465s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:18.070s > [INFO] Finished at: Wed Mar 04 18:56:21 UTC 2015 > [INFO] Final Memory: 99M/866M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
