> On March 5, 2015, 11:17 a.m., Jaideep dhok wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java, > > line 75 > > <https://reviews.apache.org/r/31670/diff/3/?file=882914#file882914line75> > > > > Delete commented code.
I'm seeing a lot of NPE on this line. So removed. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31670/#review75298 ----------------------------------------------------------- On March 3, 2015, 5:27 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31670/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 5:27 p.m.) > > > Review request for lens. > > > Bugs: LENS-168 > https://issues.apache.org/jira/browse/LENS-168 > > > Repository: lens > > > Description > ------- > > added validationQuery > > > Diffs > ----- > > > lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java > 05964e1021910038f46a2ca141d1bf56ee2f4e03 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > ca87fa3e12f1b117c1249e27056cff41036c1ccf > lens-server/src/main/java/org/apache/lens/server/LensService.java > dd6d41c8ad6ef855184cab1c6c108989d20da366 > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 3f2e8176e269604fc09dc72f0577af8d960f803d > lens-server/src/main/resources/lensserver-default.xml > 4b60cd5b92d4f2c1db8f8a9e6cebccc80adbe74a > lens-server/src/test/resources/lens-site.xml > 118ecdcf31679f6c03406ee5eb3fc162c3573367 > src/site/apt/admin/config.apt 6445fe734fe8fc5082aba06c61ec3a5dc35a7b61 > src/site/apt/admin/session-config.apt > d1c36bb91b4829b9fa40836c1ca2191ee4d3017b > > Diff: https://reviews.apache.org/r/31670/diff/ > > > Testing > ------- > > mvn clean install -DskipTests passes. > > No new tests added, new config param also not used in test cases. Since it's > not breaking anything, can push it. > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.009s] > [INFO] Lens .............................................. SUCCESS [2.057s] > [INFO] Lens API .......................................... SUCCESS [5.487s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.173s] > [INFO] Lens Cube ......................................... SUCCESS [6:13.074s] > [INFO] Lens DB storage ................................... SUCCESS [9.809s] > [INFO] Lens Query Library ................................ SUCCESS [4.578s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:33.976s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [25.457s] > [INFO] Lens Server ....................................... SUCCESS [4:26.229s] > [INFO] Lens client ....................................... SUCCESS [20.279s] > [INFO] Lens CLI .......................................... SUCCESS [1:40.666s] > [INFO] Lens Examples ..................................... SUCCESS [0.780s] > [INFO] Lens Distribution ................................. SUCCESS [9.389s] > [INFO] Lens ML Lib ....................................... SUCCESS [44.977s] > [INFO] Lens Regression ................................... SUCCESS [0.478s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:06.331s > [INFO] Finished at: Tue Mar 03 07:58:45 UTC 2015 > [INFO] Final Memory: 109M/991M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
