-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32281/
-----------------------------------------------------------
(Updated March 20, 2015, 8:56 a.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-404
https://issues.apache.org/jira/browse/LENS-404
Repository: lens
Description
-------
Changes include :
- getAll* methods in cube metastore are responded through cache
- isCube and isDimension calls changed to look at allCubes and allDimensions
instead of hitting metastore when table does not exist
- Changed the caching keys to have .trim().toLowercase() on all
updates/lookups. They are lookups/updates in code which dont trim names, wanted
to the cache to agnostic to those.
- Changed multiple calls of getClient(sessionid) in CubeMetastoreService in
single method, as getClient() is not trivial call
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
83fb8c8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java
a188a41
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
e0e87ab
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
61e511f
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
8ea6547
Diff: https://reviews.apache.org/r/32281/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.130s]
[INFO] Lens .............................................. SUCCESS [1.841s]
[INFO] Lens API .......................................... SUCCESS [5.383s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.997s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.562s]
[INFO] Lens DB storage ................................... SUCCESS [10.623s]
[INFO] Lens Query Library ................................ SUCCESS [4.815s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.685s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.707s]
[INFO] Lens Server ....................................... SUCCESS [4:14.833s]
[INFO] Lens client ....................................... SUCCESS [20.686s]
[INFO] Lens CLI .......................................... SUCCESS [3:54.751s]
[INFO] Lens Examples ..................................... SUCCESS [0.862s]
[INFO] Lens Distribution ................................. SUCCESS [9.474s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.285s]
[INFO] Lens Regression ................................... SUCCESS [0.479s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:52.073s
[INFO] Finished at: Fri Mar 20 08:52:23 UTC 2015
[INFO] Final Memory: 111M/1226M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
