----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32718/#review78515 -----------------------------------------------------------
Ship it! lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java <https://reviews.apache.org/r/32718/#comment127337> Can we store this in a local variable instead? This will avoid repeated calls to ctx.getDriverConf - Jaideep dhok On April 1, 2015, 12:24 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32718/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 12:24 p.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-480 > https://issues.apache.org/jira/browse/LENS-480 > > > Repository: lens > > > Description > ------- > > Priority is not getting set on the jobs launched because conf was being set > in driver query conf, but read from context query conf. Fixed the usage of > QueryContext.getConf in HiveDriver. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > a230515 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 36594e9 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 5c70a89 > > Diff: https://reviews.apache.org/r/32718/diff/ > > > Testing > ------- > > Awaiting test results > > > Thanks, > > Amareshwari Sriramadasu > >
