----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32719/#review78539 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java <https://reviews.apache.org/r/32719/#comment127364> This is already taken care during AST traversal, this while loop is not required lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java <https://reviews.apache.org/r/32719/#comment127366> Non queryable fields here are dim attributes accessed in where and group by, and chain.column attributes accessed in where and group by. Not all fields from all chains and all queried dim attributes as it is getting calculated as of now. - Amareshwari Sriramadasu On April 1, 2015, 1:25 p.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32719/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 1:25 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-473 > https://issues.apache.org/jira/browse/LENS-473 > > > Repository: lens > > > Description > ------- > > Changes - > 1. Refactored validation code into a separate resolver, adding it after group > by resolver > 2. Doing validation only on columns in group by and where clauses. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > d81fab1d18f865db5e3c2c7f8b3328bc3210f1aa > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 1833cde9c2a807136079152faa9f177efb9a291f > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 632829fbd04ede60985508cf2c79500978ad3076 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > aec0828484c3616ec5ef896a9a06eacf4beb2491 > > Diff: https://reviews.apache.org/r/32719/diff/ > > > Testing > ------- > > I'll add new failing test. > All existing lens-cube tests passing. Awaiting full test results. > > > Thanks, > > Jaideep dhok > >
