Himanshu Gahlaut created LENS-483:
-------------------------------------
Summary: Consistent way of receiving request data in REST APIs
Key: LENS-483
URL: https://issues.apache.org/jira/browse/LENS-483
Project: Apache Lens
Issue Type: Sub-task
Reporter: Himanshu Gahlaut
Lets take example of createCube and createFact.
createCube accepts LensSessionHandle as query param and XCube as entity.
@POST
@Path("cubes")
public APIResult createNewCube(@QueryParam("sessionid") LensSessionHandle
sessionid, XCube cube)
On the other hand, createFact consumes multi part form data and accepts
LensSessionHandle and XFactTable as form data params.
@Consumes({MediaType.MULTIPART_FORM_DATA})
@POST
@Path("/facts")
public APIResult createFactTable(@FormDataParam("sessionid") LensSessionHandle
sessionid, @FormDataParam("fact") XFactTable fact)
createFact and createCube are logically similar but still have different ways
of receiving request data in REST API.
Logically similar APIs should choose same method to receive request data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)