> On April 7, 2015, 3:17 p.m., Amareshwari Sriramadasu wrote: > > Ship It!
This review request just adds validation on client side. I'm not sure whether we should do a validation on server side as well. The problem will only occur if client and server have different versions of the xsd. For that case we should require client to pass it's version to server and have server determine whether the versions are compatible or not. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32881/#review79156 ----------------------------------------------------------- On April 7, 2015, 1:58 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32881/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 1:58 p.m.) > > > Review request for lens. > > > Bugs: LENS-472 > https://issues.apache.org/jira/browse/LENS-472 > > > Repository: lens > > > Description > ------- > > 1. add partition -> add single-partition > 2. lens client does validation of xml before sending to server. > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5a3fef38ff05dafbd1b6c510ff66281575358de7 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 47686e905d11af97cffc68e4d0b24bef0d8a3552 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > f22515508cd4ceaf7b67ba4cb40ce0df8bf2ac6a > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 3462dc3d6af807ef248e9ee0fbdff27cd0137b2c > > Diff: https://reviews.apache.org/r/32881/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
