> On April 7, 2015, 3 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 89 > > <https://reviews.apache.org/r/32882/diff/2/?file=916471#file916471line89> > > > > Why is this config required? I could not understand why a new config is > > required when we already have partial data flag. Why is 'no partitions' not > > same as partial data?
Exactly. Angad had some issues with the definition of `partial`, saying that `partial` shouldn't include `none`. The ask is that when the user says that partial data is okay, it means that it should still be the most correct data among all possible options. This includes pruning of empty facts if non-empty facts are able to answer. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32882/#review79155 ----------------------------------------------------------- On April 6, 2015, 7:57 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32882/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 7:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-482 > https://issues.apache.org/jira/browse/LENS-482 > > > Repository: lens > > > Description > ------- > > Just code changes right now. Will think about adding test cases later. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > a6374f6 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 6e63483 > > Diff: https://reviews.apache.org/r/32882/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.168s] > [INFO] Lens .............................................. SUCCESS [1.853s] > [INFO] Lens API .......................................... SUCCESS [5.197s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.380s] > [INFO] Lens Cube ......................................... SUCCESS [2:19.117s] > [INFO] Lens DB storage ................................... SUCCESS [9.418s] > [INFO] Lens Query Library ................................ SUCCESS [4.806s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:28.797s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [18.452s] > [INFO] Lens Server ....................................... SUCCESS [4:49.105s] > [INFO] Lens client ....................................... SUCCESS [20.570s] > [INFO] Lens CLI .......................................... SUCCESS [2:29.312s] > [INFO] Lens Examples ..................................... SUCCESS [0.752s] > [INFO] Lens Distribution ................................. SUCCESS [10.372s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:07.589s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.842s] > [INFO] Lens Regression ................................... SUCCESS [0.632s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:38.261s > [INFO] Finished at: Mon Apr 06 14:22:54 UTC 2015 > [INFO] Final Memory: 108M/1244M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
