> On April 7, 2015, 12:24 p.m., Himanshu Gahlaut wrote: > > pom.xml, line 1240 > > <https://reviews.apache.org/r/32924/diff/2/?file=919156#file919156line1240> > > > > Isn't mvn clean install -Dfindbugs.skip=true good enough to disable > > findbugs ? > > http://mojo.codehaus.org/findbugs-maven-plugin/findbugs-mojo.html#skip > > > > Do we need this profile ? > > Amareshwari Sriramadasu wrote: > -Dfindbugs.skip=true will fully skip running findbugs. This profile is > still running findbugs and prining warnings, but not failing the build. This > will allow new code written to have a look at all warnings without build > failures, when we enable failonerror to true. > > Himanshu Gahlaut wrote: > Can we achieve the same by passing -Dfindbugs.failOnError=false during > build ? > http://mojo.codehaus.org/findbugs-maven-plugin/findbugs-mojo.html#failOnError
Yes. Should be fine. We can revert the adding the profile changes. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32924/#review79167 ----------------------------------------------------------- On April 7, 2015, 10:32 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32924/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 10:32 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-353 > https://issues.apache.org/jira/browse/LENS-353 > > > Repository: lens > > > Description > ------- > > Adds the findbug maven plugin in pom and included and empty exclude file, > which does not exclude anything. Disabled failonerror right now. > > > Diffs > ----- > > checkstyle/src/main/resources/findbugs-exclude.xml PRE-CREATION > pom.xml f306ee0 > > Diff: https://reviews.apache.org/r/32924/diff/ > > > Testing > ------- > > mvn clean install -DskipTests passes. > mvn clean install findbugs:findbugs -DskipTests gives all the warnings. > mvn clean install -DskipTests -Pno-fail-on-findbugs passes and gives all > warnings. > > INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-api --- > [INFO] BugInstance size is 6 > [INFO] Error size is 0 > [INFO] Total bugs: 6 > > ---- > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-server-api --- > [INFO] BugInstance size is 11 > [INFO] Error size is 0 > [INFO] Total bugs: 11 > > ---- > > INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-cube --- > [INFO] BugInstance size is 63 > [INFO] Error size is 0 > [INFO] Total bugs: 63 > > ---- > > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-query-lib --- > [INFO] BugInstance size is 8 > [INFO] Error size is 0 > [INFO] Total bugs: 8 > > ---- > > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-driver-hive --- > [INFO] BugInstance size is 8 > [INFO] Error size is 0 > [INFO] Total bugs: 8 > > ---- > > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ > lens-driver-jdbc --- > [INFO] BugInstance size is 6 > [INFO] Error size is 0 > [INFO] Total bugs: 6 > > ---- > > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-server > --- > [INFO] BugInstance size is 45 > [INFO] Error size is 0 > [INFO] Total bugs: 45 > > ---- > > INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-client --- > [INFO] BugInstance size is 4 > [INFO] Error size is 0 > [INFO] Total bugs: 4 > > ---- > > INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-cli --- > [INFO] BugInstance size is 2 > [INFO] Error size is 0 > [INFO] Total bugs: 2 > > ---- > > [INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-examples > --- > [INFO] BugInstance size is 7 > [INFO] Error size is 0 > [INFO] Total bugs: 7 > > ---- > > INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ lens-ml-lib --- > [INFO] BugInstance size is 22 > [INFO] Error size is 0 > [INFO] Total bugs: 22 > > > Thanks, > > Amareshwari Sriramadasu > >
