> On April 9, 2015, 7:01 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/product_table.xml, line 29
> > <https://reviews.apache.org/r/33003/diff/2/?file=921319#file921319line29>
> >
> >     Would it make sense to add category to partition columns instead of 
> > columns?

We can do once we have full support for non time partition columns, after 
LENS-455.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33003/#review79487
-----------------------------------------------------------


On April 9, 2015, 5:24 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33003/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 5:24 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and sharad agarwal.
> 
> 
> Bugs: LENS-491
>     https://issues.apache.org/jira/browse/LENS-491
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added example schema with e-commerce usecase. Added the following :
> sales cube, Dimensions - customer, proudct and city.
> Added fact tables - raw and two aggregate facts. Raw in HDFS storage and 
> aggregates in both HDFS and DB storage.
> Added product and customer tables in both HDFS and DB storages. Added full 
> city table in HDFS and subset in DB.
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 
> cdfdbe8 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 
> 3c8cb3a 
>   lens-examples/src/main/java/org/apache/lens/examples/DatabaseUtil.java 
> 9bcbd9a 
>   
> lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java
>  6604553 
>   lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 
> 09be3f2 
>   lens-examples/src/main/resources/city.xml PRE-CREATION 
>   lens-examples/src/main/resources/city_subset.xml PRE-CREATION 
>   lens-examples/src/main/resources/city_table.xml PRE-CREATION 
>   lens-examples/src/main/resources/customer.xml PRE-CREATION 
>   lens-examples/src/main/resources/customer_table.xml PRE-CREATION 
>   lens-examples/src/main/resources/db-storage-schema.sql 160590f 
>   lens-examples/src/main/resources/product.xml PRE-CREATION 
>   lens-examples/src/main/resources/product_table.xml PRE-CREATION 
>   lens-examples/src/main/resources/sales-aggr-fact1.xml PRE-CREATION 
>   lens-examples/src/main/resources/sales-aggr-fact2.xml PRE-CREATION 
>   lens-examples/src/main/resources/sales-cube.xml PRE-CREATION 
>   lens-examples/src/main/resources/sales-raw-fact.xml PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 138797e 
> 
> Diff: https://reviews.apache.org/r/33003/diff/
> 
> 
> Testing
> -------
> 
> Tested creating sample metastore. Validated cube, dimension, dimtables, 
> facttable definitions through show and describe. Validated some queries by 
> checking right facts are picked, by making fail on partial data off 
> 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.103s]
> [INFO] Lens .............................................. SUCCESS [1.821s]
> [INFO] Lens API .......................................... SUCCESS [5.853s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.392s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.779s]
> [INFO] Lens DB storage ................................... SUCCESS [9.791s]
> [INFO] Lens Query Library ................................ SUCCESS [4.653s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:32.643s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [19.641s]
> [INFO] Lens Server ....................................... SUCCESS [4:47.881s]
> [INFO] Lens client ....................................... SUCCESS [20.251s]
> [INFO] Lens CLI .......................................... SUCCESS [2:46.304s]
> [INFO] Lens Examples ..................................... SUCCESS [0.789s]
> [INFO] Lens Distribution ................................. SUCCESS [9.404s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.792s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.474s]
> [INFO] Lens Regression ................................... SUCCESS [0.451s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 14:55.019s
> [INFO] Finished at: Thu Apr 09 05:16:25 UTC 2015
> [INFO] Final Memory: 108M/1119M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to