> On April 13, 2015, 10:12 a.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/product_table.xml, line 46 > > <https://reviews.apache.org/r/33122/diff/1/?file=925201#file925201line46> > > > > We need to take care of populating partitions as well in LENS-496. Can > > you merge and take care of ? > > Rajat Khandelwal wrote: > Which one should we push first? pushing 496 first would have 455 modify a > lot of code of 499 thus breaking separation of concerns.
Lets get this in. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33122/#review79850 ----------------------------------------------------------- On April 13, 2015, 12:53 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33122/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 12:53 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-455 > https://issues.apache.org/jira/browse/LENS-455 > > > Repository: lens > > > Description > ------- > > making partition columns valid queryable columns. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd > 1de42585511f7f6602138fdeb2aa1de9d942f580 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java > 33e0482259e1f3e8f76e3665aa2315c9834d4206 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > e25fc8124c92d2aa3cba059030dcfdcb923fc037 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 30253d3e13449f824050fe47351eda83d2cec8cb > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java > 90d0b6df94d885d92976aac7044b43d88ceca25b > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > bc9ef93071a41863bd159e45571944d332bf0d89 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > fe29d257bb2df55a29f4d50cb7e57335b70e533a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 62b2c95904e2845a588a48cf765fa4c08601b5cf > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 6c659536c2eaf90b7c16ec5b1a567189cf4d3df9 > lens-examples/src/main/resources/product_table.xml > 4babca663f3ded98e7c6be55c44a975f5f25b70e > > Diff: https://reviews.apache.org/r/33122/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.105s] > [INFO] Lens .............................................. SUCCESS [2.823s] > [INFO] Lens API .......................................... SUCCESS [16.153s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.565s] > [INFO] Lens Cube ......................................... SUCCESS [2:45.481s] > [INFO] Lens DB storage ................................... SUCCESS [21.583s] > [INFO] Lens Query Library ................................ SUCCESS [18.083s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:48.983s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [33.234s] > [INFO] Lens Server ....................................... SUCCESS [5:19.709s] > [INFO] Lens client ....................................... SUCCESS [37.921s] > [INFO] Lens CLI .......................................... SUCCESS [2:54.453s] > [INFO] Lens Examples ..................................... SUCCESS [9.762s] > [INFO] Lens Distribution ................................. SUCCESS [10.193s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.515s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.622s] > [INFO] Lens Regression ................................... SUCCESS [0.465s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:08.613s > [INFO] Finished at: Mon Apr 13 06:09:54 UTC 2015 > [INFO] Final Memory: 113M/1255M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
