> On April 14, 2015, 1:11 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java, > > line 387 > > <https://reviews.apache.org/r/33162/diff/1/?file=926822#file926822line387> > > > > Can we add getAllFactTablesOfCube also on similar lines? > > > > CLI is not required?
We already have `getAllFactsOfCube`. Will add CLI for both. > On April 14, 2015, 1:11 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 483 > > <https://reviews.apache.org/r/33162/diff/1/?file=926823#file926823line483> > > > > Does it really have to give full XDimensionTable object? Or names > > suffice? Converting it to return StringList now. Since url `/facts` returns `StringList`, `/cubes/cubename/facts` should also return same type. Same thing for dimtables. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33162/#review79999 ----------------------------------------------------------- On April 14, 2015, 5:09 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33162/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 5:09 p.m.) > > > Review request for lens. > > > Bugs: LENS-441 > https://issues.apache.org/jira/browse/LENS-441 > > > Repository: lens > > > Description > ------- > > adding REST method for getting all dimtables of a dimension > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > c61be09a3c9719dc8cf8141225d090077d8a05c7 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > a69d3611e554436e68b01ee255338d728362b405 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 5430c7f85fcd6b084bd20f391e92eab0d08b35b0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 244b9ec8b71dcd7f09d56b1bb9f89fc8522406a9 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 449c8ec4108a4edec0f8916433e138d734fd6709 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 1e243e8a303cddb93795f3ae191b3a45726112f2 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > fa56213b4f67ded1b483e907f07fee0749ec5ecc > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a1022fde77142181d4228e43f1fd3fc5bad2e39d > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 9ceea48afeaf9dee17fc36a9913ff3a62e8f7435 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 9de5f79a7b04ab09c753d06a835a94eaea7bbe1a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 0e6d05709dd66165e0eebdeb494096ae85955b68 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 06c352e50eb012177919ac27b6af6eed27a52318 > > Diff: https://reviews.apache.org/r/33162/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
