> On April 10, 2015, 4:44 p.m., Amareshwari Sriramadasu wrote: > > lens-regression/pom.xml, line 56 > > <https://reviews.apache.org/r/33068/diff/2/?file=923517#file923517line56> > > > > Are profile definitions required again here? I think main pom's > > definitions should suffice. Defining them again shouldnt be required unless > > something is getting overridden. > > Arshad Matin wrote: > In lens-regression pom, "unit-tests" profile is defined which is active > by default, now running with any other profile from parent's pom will run all > the module with that profile properties except lens-regression, unless we > define that profile in its pom too. For lens-regression it will always choose > the default one if the profile is not defined in its pom. > > The other way of doing is to define a "unit-tests" profile which will be > active by default in parent pom. Then we dont need to define profiles in sub > modules. > > Amareshwari Sriramadasu wrote: > we can skip *IT*.java tests in surefire-plugin's parent pom. Making > unit-test default will make other profiles always this profile along. so, let > us not do. > > Arshad Matin wrote: > Have removed profile from lens-regression's pom. And skipped IT.java > tests in surefire-plugin's parent pom > > Himanshu Gahlaut wrote: > Integration tests can also be run without creating a separate profile for > them. Maven failsafe plugin is designed to run integration tests. More > reading: http://maven.apache.org/surefire/maven-failsafe-plugin/ > > After configuring pom as given below, "mvn test" will not run integration > tests and "mvn verify" will run integration tests. > > <plugins> > > <!-- exclude Integration Tests in maven sure fire plugin --> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-surefire-plugin</artifactId> > <version>2.18.1</version> > <configuration> > <excludes> > <exclude>**/*IT*</exclude> > </excludes> > </configuration> > </plugin> > > <!-- Add maven fail safe plugin to run integration tests --> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-failsafe-plugin</artifactId> > <version>2.17</version> > <executions> > <execution> > <goals> > <goal>integration-test</goal> > <goal>verify</goal> > </goals> > </execution> > </executions> > </plugin> > > </plugins>
The tests added here are actually not integration tests. They would be run on a deployement. So, failsafe-plugin would not work. Should we rename the profile to regression-tests or someother instead of integration-tests? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33068/#review79693 ----------------------------------------------------------- On April 15, 2015, 1:08 p.m., Arshad Matin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33068/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 1:08 p.m.) > > > Review request for lens. > > > Bugs: https://issues.apache.org/jira/browse/LENS-243 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/LENS-243 > > > Repository: lens > > > Description > ------- > > LENS-243:Add smoke test as a part of lens-regression > > > Diffs > ----- > > lens-regression/pom.xml 07441bc23de6f8dc8ff65a5c89a42f6dba181ac6 > > lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java > PRE-CREATION > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > PRE-CREATION > lens-regression/src/main/resources/lens.properties PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java > PRE-CREATION > lens-regression/src/test/resources/result.data PRE-CREATION > pom.xml f306ee01742d248ec86d22ba792c7cae75259a1e > > Diff: https://reviews.apache.org/r/33068/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 22.886 > s] > [INFO] Lens ............................................... SUCCESS [ 10.057 > s] > [INFO] Lens API ........................................... SUCCESS [ 12.752 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 27.587 > s] > [INFO] Lens Cube .......................................... SUCCESS [05:00 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 41.912 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 9.699 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [03:41 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 28.625 > s] > [INFO] Lens Server ........................................ SUCCESS [21:05 > min] > [INFO] Lens client ........................................ SUCCESS [ 48.677 > s] > [INFO] Lens CLI ........................................... SUCCESS [04:45 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 3.930 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 27.148 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:49 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 24.547 > s] > [INFO] Lens Regression .................................... SUCCESS [ 1.817 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41:43 min > [INFO] Finished at: 2015-04-10T12:28:53+05:30 > [INFO] Final Memory: 82M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Arshad Matin > >
