> On April 29, 2015, 5:31 a.m., Amareshwari Sriramadasu wrote: > > Couple of questions : > > > > - Can we put up End to end handling of request and response - on success, > > on failure? Right now, i can understand the flow from code changes put up > > and testcases. But not very clear for me, i think it might be the same for > > clients as well. > > - How many more changes are required for the all errors to propogate from > > all api? This is to get an estimate of how much more work is there.
https://issues.apache.org/jira/browse/LENS-529 https://issues.apache.org/jira/browse/LENS-530 Tickets parked for documentation. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33213/#review81931 ----------------------------------------------------------- On April 28, 2015, 1:49 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33213/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 1:49 p.m.) > > > Review request for lens. > > > Bugs: LENS-486 > https://issues.apache.org/jira/browse/LENS-486 > > > Repository: lens > > > Description > ------- > > LENS-486 > > Please refer description of LENS-486 for summary and spreadsheet available in > LENS-395 for overall design. > > > Diffs > ----- > > lens-api/pom.xml f5fd73db47a2e5ed2c1aef256c2a6b22f028d462 > lens-api/src/main/java/org/apache/lens/api/LensException.java > b0a944acacb5afecb0f19645b738fd72ea904fd8 > lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java > b3aa584f18a207036a5f42817f03fb586c1f029f > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollection.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/error/ErrorMap.java PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/error/LensError.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/error/LensMultiCauseException.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java > 0bb385778d07b501d1dfd6e25d41b33d328d63e1 > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java > 189630814655f01e02d2e2b004733b7ec0f8436f > lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java > 5228af2563052fec5ed5df2b518cd7a9252d6f9b > lens-api/src/main/java/org/apache/lens/api/response/LensErrorTO.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/response/LensJAXBContextResolver.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/response/NoErrorPayload.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/response/NoSuccessResponseData.java > PRE-CREATION > lens-api/src/main/resources/lens-errors.conf PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > b19ccd1ea526ac5ac5ae05144d00b04adfb4925c > lens-cube/pom.xml 47601c190e5fb4474ceeb7e66240f962e929109e > > lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRange.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java > 3618733b2dddc0d1d84a152a65ab7a630a224317 > lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java > 6be08bdc89a35f651fe0cb491ea1a82a113a7749 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > e40df44224f0bf84f3cfbf5168915183592b1ac8 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 11eb345afeb32057e00106650d017e602add37b3 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > c73b7ffae47834eb6e0d84f56df7de8400641745 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 04be157ad9940111ae0ec65740fb09ecfb80023f > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 5d9e97ecea541e0d82a22ab8365f79f2983d6695 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 965ec9447a9f364df2f0e1d68d1414dafcce4bbf > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 097f2283b7defb2fe5703cf04f3dc276f18e341b > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > c9972e23419a00fb5729b854b8feea9b44b125a3 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > aa57c7d5a178c2e5eea4642403c66b36d5ddc68c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 8761c5148d0932b0a08c81de4ff40bbe9b8c249e > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > cb078e3e71e20298cfd0b5f2d8715dcd6150a14b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > c4449dae8367b8ef71691c034dff9dcabb466d9c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > f039977b74498397f8bcc4a68e8603bebffa9c69 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java > f19221b0548196b3a88dd0451ed24035696e6e35 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > c64a270448800b296a5520fba4bd9de4baf6a6d1 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 749e0dd14dd5debbbecea6d3dcca41d79cc54e6d > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 2346b52c11e2a8af9a5df7fbdaab70e0d314fcce > lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java > aff7c846f0316114e5460f7ed6e2a8beb8ecdb67 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 225eb56d4770e60e680beee32dc0997d7a1c94f7 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 5f21501cee51d3817fbbeb410ce26c197a4138ac > lens-server/pom.xml 6bbb715b1c11ae5bc1cb6d2240c4f9353f81d636 > lens-server/src/main/java/org/apache/lens/server/LensServer.java > 2f83fe1c46821fb8844ea405680da6a104ba75d6 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > f6cb365dc35c016fca2edb3cf70b70448c993cf3 > > lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8a6cd0723597c43a0df9b60a9a39de71bf > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 4b914f28170089e9a6af7f915d3b16f6d6d15a3d > > lens-server/src/main/java/org/apache/lens/server/query/SupportedQuerySubmitOperations.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java > 5658d47237a6f6a84f741b23d45231d85b89a016 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 86bec3ac6874e9166afe7f32f177c9a52150fbe1 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > b634701380b00890a9c32c4cfe21082b273f3906 > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/TestResourceFile.java > 1ea53af44f9347eeee447e18a9b4192b6ddfdba5 > > lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java > 973dd73eef7b65c6c2942b9a8bf56560b20fb9e5 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 6a24f8f6e83c500616e48a31217cf1737528370a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > ed4749f0dd1de6c52b9d3fba98180aa9da3bcff6 > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > e18a90f88c5ac8dbea17aeba7e4ca95c2a5699b9 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104deb15b547446dfae78c286a9b207da863 > lens-server/src/test/resources/log4j.properties PRE-CREATION > pom.xml a0744e4da177947680a6fbc81bbab6456224b602 > > Diff: https://reviews.apache.org/r/33213/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.629s] > [INFO] Lens .............................................. SUCCESS [5.436s] > [INFO] Lens API .......................................... SUCCESS [9.053s] > [INFO] Lens API for server and extensions ................ SUCCESS [9.583s] > [INFO] Lens Cube ......................................... SUCCESS [2:50.522s] > [INFO] Lens DB storage ................................... SUCCESS [17.363s] > [INFO] Lens Query Library ................................ SUCCESS [6.416s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:12.563s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [26.651s] > [INFO] Lens Server ....................................... SUCCESS > [31:53.796s] > [INFO] Lens client ....................................... SUCCESS [47.945s] > [INFO] Lens CLI .......................................... SUCCESS [4:55.887s] > [INFO] Lens Examples ..................................... SUCCESS [1.925s] > [INFO] Lens Distribution ................................. SUCCESS [14.510s] > [INFO] Lens ML Lib ....................................... SUCCESS [3:14.719s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [29.213s] > [INFO] Lens Regression ................................... SUCCESS [0.611s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 49:01.723s > [INFO] Finished at: Wed Apr 15 14:44:37 IST 2015 > [INFO] Final Memory: 101M/346M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
