----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30791/#review82096 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java <https://reviews.apache.org/r/30791/#comment132763> Can we keep this section in try finally block? lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java <https://reviews.apache.org/r/30791/#comment132762> Can we say file/directory path instead of only file path? Can you update the site documentation with this command? - Raju Bairishetti On Feb. 9, 2015, 2:54 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30791/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 2:54 p.m.) > > > Review request for lens. > > > Bugs: LENS-26 > https://issues.apache.org/jira/browse/LENS-26 > > > Repository: lens > > > Description > ------- > > add option to download result > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 4721d2a7301fa831690f10797bca2ff1efc34b2b > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 016e35e17c91e4356bddc962416874b80dd443bc > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 73d53f60f758b69c45a093f897008f17dd3d036f > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 2c8ee78be6f9c64df3c44ea84ef837aabb60cdba > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java > 5cf282e9ab044928bdc50e65358c804a83519151 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 4890d79c2220745587a7a740033cd09f2621d416 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 02bf3241abe0e9f84ae99e92fc2edbc68fd639b3 > > Diff: https://reviews.apache.org/r/30791/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.165s] > [INFO] Lens .............................................. SUCCESS [1.776s] > [INFO] Lens API .......................................... SUCCESS [5.682s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.074s] > [INFO] Lens Cube ......................................... SUCCESS [6:14.698s] > [INFO] Lens DB storage ................................... SUCCESS [10.401s] > [INFO] Lens Query Library ................................ SUCCESS [4.804s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:43.913s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [24.032s] > [INFO] Lens Server ....................................... SUCCESS [4:35.401s] > [INFO] Lens client ....................................... SUCCESS [22.221s] > [INFO] Lens CLI .......................................... SUCCESS [1:24.482s] > [INFO] Lens Examples ..................................... SUCCESS [0.864s] > [INFO] Lens Distribution ................................. SUCCESS [4.526s] > [INFO] Lens Client Distribution .......................... SUCCESS [5.937s] > [INFO] Lens ML Lib ....................................... SUCCESS [42.770s] > [INFO] Lens Regression ................................... SUCCESS [0.477s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:10.128s > [INFO] Finished at: Mon Feb 09 12:03:44 UTC 2015 > [INFO] Final Memory: 99M/1134M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
