Yash, Feel free to comment on the respective jiras the approach you are thinking. That will make all discussion related to jira captured on jira directly.
Thanks Amareshwari On Fri, May 1, 2015 at 1:08 AM, Yash Sharma <[email protected]> wrote: > Hi Team, > I would like to pick up LENS-484 > <https://issues.apache.org/jira/browse/LENS-484> and LENS-479 > <https://issues.apache.org/jira/browse/LENS-479> next if no one is working > on it already. > > LENS-484: > "NPE when weight is not set in XFactTable object while creating fact table" > Approach: I am planning to handle the NPE and log the error message. > Alternatively, Let me know if we would like to have this weight as a > required field. > Class#Method: CubeMetastoreServiceImpl#createFactTable > > LENS-479: > "Add server state persisting error counter" > Approach: Having a static counter in LensServices. Since all methods > persisting the server state in LensServices are in synchronized blocks we > might not need a Atomic Integer and plain static integer should suffice. We > can also log the count everytime we hit failure while state persistence. > Class#Method: LensServices#start, LensServices#persistLensServiceState > > Please share your thoughts. I might be missing something. > > Thanks >
