Re: Review Request 33392: LENS-256: lens-cli should not use single parameter for two values

[Rajat Khandelwal]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33392/
-----------------------------------------------------------

(Updated May 5, 2015, 8:05 p.m.)


Review request for lens.


Bugs: LENS-256
    https://issues.apache.org/jira/browse/LENS-256


Repository: lens


Description
-------

Re-opening it as fresh issue as CLI had a lot of changes recently. 
Will update user doc if changes look fine.


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 
bf90cdc239d55cbf0de1d56732d5f62fbf4d0298 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 
PRE-CREATION 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java
 PRE-CREATION 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 
b6be2e0c9dca37f92f83820f9c908450aeddcb6d 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
675e830f746eee897896fd8f2419e8273b9de9a4 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
f030d0d0ecbe18344291c94cb2d7e96b9ccbc75a 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 
7539ea9761df15e2ca1847be20d8ac738e13df71 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
 c3b7f37bb8d79bf8d21c104465bcb15f9371bb94 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
1e8abf92f823aaebaf7ee80e2c4ff0ccb0c8bffa 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
 3dc29a7dd2e275318d0417eea351027e6f7e2703 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
920ba9c53ed86726e6c5d712a560d67ec60fa3b7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 
d2dc6e5e8909a9df9ef49e1d073e460e27333058 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/UserDocumentation.java
 PRE-CREATION 
  lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml 
24a35fd5fd66d10357f31de7da6478813638bba9 
  lens-cli/src/test/java/org/apache/lens/cli/TestGenerateCLIUserDoc.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
8334317cd63854cd24d2883bd25f1f4279a58a46 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
cabe3a56e9cb59b0d429ec7fc14780b7ad94f749 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
aa289d3caa4906c8881041ef478713e6dbe18088 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 
3cbeed1eed2c86c1f30594431ed44c870f7fd124 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 
02f5ac7c5cfd61463a48d8b7ed3b01b4bac6e73e 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
a48734abd98e7965045c53fc018e181f22b66d52 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 
9772849a60906aee4ca3512a4d724ca7403976b8 

Diff: https://reviews.apache.org/r/33392/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.175s]
[INFO] Lens .............................................. SUCCESS [2.350s]
[INFO] Lens API .......................................... SUCCESS [17.931s]
[INFO] Lens API for server and extensions ................ SUCCESS [25.124s]
[INFO] Lens Cube ......................................... SUCCESS [2:47.185s]
[INFO] Lens DB storage ................................... SUCCESS [19.303s]
[INFO] Lens Query Library ................................ SUCCESS [18.114s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.814s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.908s]
[INFO] Lens Server ....................................... SUCCESS [5:17.391s]
[INFO] Lens client ....................................... SUCCESS [36.315s]
[INFO] Lens CLI .......................................... SUCCESS [3:06.983s]
[INFO] Lens Examples ..................................... SUCCESS [9.486s]
[INFO] Lens Distribution ................................. SUCCESS [10.963s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.943s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.785s]
[INFO] Lens Regression ................................... SUCCESS [0.515s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal