> On May 8, 2015, 11:47 a.m., Rajat Khandelwal wrote: > > tools/scripts/lens-patch-review.py, line 75 > > <https://reviews.apache.org/r/33943/diff/3/?file=952345#file952345line75> > > > > rbtools command is `rbt`, not `post-review` > > Rajat Khandelwal wrote: > Let's use `rbt` command, which requires only one time setup for > username/password. Apart from that, we only need version number. This can be > obtained by running > ``` > $ rbt api-get /review-requests/33943/diffs > {"total_results": 3, "diffs": [{"base_commit_id": null, "name": "diff", > "links": {"files": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/1/files/";, > "method": "GET"}, "self": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/1/";, "method": > "GET"}, "update": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/1/";, "method": > "PUT"}, "repository": {"href": > "https://reviews.apache.org/api/repositories/146/";, "method": "GET", "title": > "lens"}}, "timestamp": "2015-05-07T16:11:14Z", "basedir": "", "extra_data": > {}, "id": 70066, "revision": 1}, {"base_commit_id": null, "name": > "LENS-541.patch", "links": {"files": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/2/files/";, > "method": "GET"}, "self": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/2/";, "method": > "GET"}, "update": {"href": > "https://reviews.apache.org/api/review-requests/33943/diffs/2/";, "method": > "PUT"}, "repository": {"href" : "https://reviews.apache.org/api/repositories/146/";, "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:15:51Z", "basedir": "", "extra_data": {}, "id": 70068, "revision": 2}, {"base_commit_id": null, "name": "LENS-541.patch", "links": {"files": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/files/";, "method": "GET"}, "self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/";, "method": "GET"}, "update": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/3/";, "method": "PUT"}, "repository": {"href": "https://reviews.apache.org/api/repositories/146/";, "method": "GET", "title": "lens"}}, "timestamp": "2015-05-07T16:34:39Z", "basedir": "", "extra_data": {}, "id": 70071, "revision": 3}], "stat": "ok", "links": {"self": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/";, "method": "GET"}, "create": {"href": "https://reviews.apache.org/api/review-requests/33943/diffs/";, "method": "POST"}}} > > ``` > > Rajat Khandelwal wrote: > Also, let's not use rbt command line, instead use rbt's python client. > > Yash Sharma wrote: > Makes sense.. post-review is an outdated use of review board, > I would add python's rbt client api for the same. > > Rajat Khandelwal wrote: > Also, I think there's an open jira in kafKa regarding using oauth instead > of username password. Can you follow up on that? > > Rajat Khandelwal wrote: > We can even create a universal script, but let's wait and see how this > turns out.
Thanks Rajat, I just saw KAFKA-1059 coz of you. But we are still on standstill since 06/Aug/14 19:11. If we need to follow that route one of our committers has to contact JIRA admis methinks. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33943/#review82991 ----------------------------------------------------------- On May 7, 2015, 4:35 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33943/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 4:35 p.m.) > > > Review request for lens. > > > Bugs: LENS-541 > https://issues.apache.org/jira/browse/LENS-541 > > > Repository: lens > > > Description > ------- > > A automated script for uploading patch to jira and reviewboard. > > > Diffs > ----- > > tools/scripts/lens-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/33943/diff/ > > > Testing > ------- > > Yes. > tested on Live Jira LENS-541 and this review board. > This review board is created by the tool. > > USAGE Example : > > python tools/scripts/lens-patch-review.py -b origin/master -j LENS-541 -rbu > yash360 -rbp PASSWORD --summary "LENS-541 : Lens patch review tool" > --description "Testing the patch review tool" --testing "Under progress" -db > --version 03 > > > Thanks, > > Yash Sharma > >
