----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34033/#review83213 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java <https://reviews.apache.org/r/34033/#comment134113> Just use `@Getter` lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java <https://reviews.apache.org/r/34033/#comment134114> I think `super()` is implicitly called without writing. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java <https://reviews.apache.org/r/34033/#comment134117> can be replaced with a foreach loop. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java <https://reviews.apache.org/r/34033/#comment134116> Not needed. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java <https://reviews.apache.org/r/34033/#comment134118> So if multiple storages have the same partition, they are unioned? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java <https://reviews.apache.org/r/34033/#comment134115> Don't need to put again. It's already present in the map. lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java <https://reviews.apache.org/r/34033/#comment134125> The two constructors can be replaces with lombok annotations: `AllArgsConstructor ` and `NoArgsConstructor` - Rajat Khandelwal On May 11, 2015, 3:27 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34033/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 3:27 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-204 > https://issues.apache.org/jira/browse/LENS-204 > > > Repository: lens > > > Description > ------- > > Support for union across two or more tables in cube query rewriting. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 47b9fc1 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee9 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 8a23ded > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > beaa551 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > e5a6b32 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 3203354 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > c915353 > > Diff: https://reviews.apache.org/r/34033/diff/ > > > Testing > ------- > > Updated unit tests wrt union support. mvn clean test is running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [8.026s] > [INFO] Lens .............................................. SUCCESS [0.299s] > [INFO] Lens API .......................................... SUCCESS [17.493s] > [INFO] Lens API for server and extensions ................ SUCCESS [15.690s] > [INFO] Lens Cube ......................................... SUCCESS [4:13.909s] > [INFO] Lens DB storage ................................... SUCCESS [16.124s] > [INFO] Lens Query Library ................................ SUCCESS [10.275s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:55.868s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [27.174s] > [INFO] Lens Server ....................................... SUCCESS > [10:18.860s] > [INFO] Lens client ....................................... SUCCESS [35.250s] > [INFO] Lens CLI .......................................... SUCCESS [5:21.299s] > [INFO] Lens Examples ..................................... SUCCESS [4.412s] > [INFO] Lens Distribution ................................. SUCCESS [2.964s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:22.502s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.153s] > [INFO] Lens Regression ................................... SUCCESS [0.909s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:38.764s > [INFO] Finished at: Mon May 11 13:59:03 GMT+05:30 2015 > [INFO] Final Memory: 85M/1078M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
