----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/ -----------------------------------------------------------
Review request for lens. Repository: lens Description ------- Initial patch for - add jar should be able to take regex path and should be able to add multiple jars. Jira: https://issues.apache.org/jira/browse/LENS-513 Diffs ----- lens-cli/pom.xml 7b98523 lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb Diff: https://reviews.apache.org/r/34105/diff/ Testing ------- Yes. Testcases: New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex Old testcase modified: TestLensConnectionCliCommands#testJarCommands Test on CLI: 1. -ve test scenario: lens-shell>add jar /home/yash/Desktop/rt.jarr No Jars found in the specified path. lens-shell>add jar /home/yash/Desktop/*.jarr No Jars found in the specified path. 2. +ve test scenario: lens-shell>add jar /home/yash/Desktop/*.jar Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ] lens-shell>list resources type=jar path=/home/yash/Desktop/mahout-core-0.9.jar type=jar path=/home/yash/Desktop/rt.jar Pending: Complete testsuite run. Thanks, Yash Sharma
