> On May 18, 2015, 8:02 a.m., Amareshwari Sriramadasu wrote: > > Since we are adding new logger in many classes here - Can we add slf4j as > > per discussion in https://issues.apache.org/jira/browse/LENS-459 ? > > Rajat Khandelwal wrote: > Yes, and please use `@lombok.extern.slf4j.Slf4j` on the class instead of > creating an object manually.
This is going to be one nasty patch. Changed ~ 400 files and still counting :) - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34286/#review84120 ----------------------------------------------------------- On May 18, 2015, 5:16 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34286/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 5:16 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > https://issues.apache.org/jira/browse/LENS-551 > > - Removed all printStackTrace from project > - Replaced by LOG.error(e.getMessage()) > - Imposed checkstyle checks for restricting printStackTrace > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml 236f977 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > d727ecc > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 5df3486 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > a98f183 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 195bd43 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > d7b6372 > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java > a6fae87 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1c375ed > > lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java > 0231e8b > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 1fe4173 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 44826bd > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java > 14e56fb > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > fef634d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java > a5f64ec > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 994a244 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java > 106660e > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > b5aaeb2 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 43985ba > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > f0566c8 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > dc30bb9 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java > e526700 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 75c428a > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 2f28e5d > lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 8ffe853 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java > 51979d8 > lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java e4c03c8 > lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java c08a5b1 > lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java > 7bf5d09 > > lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java > 61a0dd8 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > b0f61b6 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > a628c90 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > ee24e1f > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > a57888d > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3bf180c > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 9b6d6bc > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > bb0d301 > > lens-server/src/main/java/org/apache/lens/server/stats/event/query/QueryExecutionStatistics.java > 4acf748 > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 859e9cc > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 885a69a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 8ecf2a8 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > 640cc41 > > lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java > bf0526f > > Diff: https://reviews.apache.org/r/34286/diff/ > > > Testing > ------- > > Tested +ve and -ve scenario with project build. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.242 > s] > [INFO] Lens ............................................... SUCCESS [ 2.553 > s] > [INFO] Lens API ........................................... SUCCESS [ 17.961 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.129 > s] > [INFO] Lens Cube .......................................... SUCCESS [02:42 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 21.738 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.051 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:40 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.985 > s] > [INFO] Lens Server ........................................ SUCCESS [05:19 > min] > [INFO] Lens client ........................................ SUCCESS [ 40.970 > s] > [INFO] Lens CLI ........................................... SUCCESS [01:57 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.992 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.871 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:18 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.419 > s] > [INFO] Lens Regression .................................... SUCCESS [ 7.997 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:04 min > [INFO] Finished at: 2015-05-16T00:31:54+05:30 > [INFO] Final Memory: 120M/318M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
