----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34348/#review84257 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java <https://reviews.apache.org/r/34348/#comment135423> get in the command does not look nice. Shall we call it "fact timelines" ? lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java <https://reviews.apache.org/r/34348/#comment135424> time dimension to filter by ? lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java <https://reviews.apache.org/r/34348/#comment135425> Why is this change required? lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java <https://reviews.apache.org/r/34348/#comment135428> I'm still wondering how DBResource tests are passing if the jars are loaded from classpath. lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java <https://reviews.apache.org/r/34348/#comment135427> Is this making test fails, if they are not failing otherwise? src/site/apt/user/cli.apt <https://reviews.apache.org/r/34348/#comment135426> This move made prepQuery command to sit different from others. Can we put it along with other prepQuery commands as earlier ? - Amareshwari Sriramadasu On May 18, 2015, 12:49 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34348/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 12:49 p.m.) > > > Review request for lens. > > > Bugs: LENS-562 > https://issues.apache.org/jira/browse/LENS-562 > > > Repository: lens > > > Description > ------- > > made all changes. > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 1c83b54e2293b7dc5ee71efdb4093746820386d1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 7ef7c23164dc8867383c1d22bd5b2b702d72629f > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 195bd435ae6eae6dd0b5988828156e7067d1b62a > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 016e4ab1285582760b5da47b355402b747ea78e8 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 5e406b567664923ca34a24c58d77bc1781f0e4dd > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 08a63b8d92474e206a1d4099f9ac262e2cf91204 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > d27e43ee95b6188f135444cb2e0c9894a5e613b8 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 1fe41737a906b9369b5cbafbfa303ab5dd777bb8 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > cde85f6c1262b1efa76839946bfd1c0f218a03c9 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > b0f61b6894770717b7ffb356fa8b9e8bcf637b19 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 73e8750aa45e9e4407d4b0e24fa6b335f5798e45 > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java > 859e9ccc947e7f06a381d2db612f676580699d12 > src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e > > Diff: https://reviews.apache.org/r/34348/diff/ > > > Testing > ------- > > unit and integration tests added > unit and integration tests added > > > Thanks, > > Rajat Khandelwal > >
