----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34210/#review84862 -----------------------------------------------------------
Changes look fine. Testing done says some tests are failing. Please fix them and update - Amareshwari Sriramadasu On May 20, 2015, 2:57 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34210/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 2:57 a.m.) > > > Review request for lens. > > > Bugs: LENS-514 > https://issues.apache.org/jira/browse/LENS-514 > > > Repository: lens > > > Description > ------- > > LENS-514: Adding unique identifier to log lines for log segregation > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java > 7b615e6216d7a31a743416dd839a63517be88e1f > lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java > efa04f1c7e7fddbd9176922425c66057f4be3089 > lens-api/src/main/java/org/apache/lens/api/response/LensResponse.java > f6c3593a131ab6779186be014d79b9f4c4cb9534 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 71fbc7454ad7f20ca674c384723e3e3300cefbc6 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 87e4638c51bb03138c41327a4228c8f9e6fbd662 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 75c428a1f70ed091bdae4597d36b334b09e91c27 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > da44955405267b35306601e1669803c82a109267 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > 1ce89ac66fa817b3e47482a81b040259d2194477 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 169ac8dec4b98a0cab1f652fe85afe9737f02e39 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 8b6d13170966123cd5d16eb9d6f476d27c46ee3d > > lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java > b64d8223727d755aad95dee288f9561b767a5448 > lens-server/src/main/java/org/apache/lens/server/LensApplication.java > cb452e83e6edbe4f13a3f29b4ce0cbe45effcde3 > > lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensServer.java > c6d7ea154f4c3f78eaa0675d99364a311351bf4c > lens-server/src/main/java/org/apache/lens/server/LensServices.java > f769619365e5f098c2634445cad788a6707ef571 > lens-server/src/main/java/org/apache/lens/server/query/QueryApp.java > 0d23726a895a11208249b7ce458cb34e2265feeb > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 1c6f18686b2cc347273ae0940797c9cfd4a5b47b > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 9b6d6bc223069b28367d789db847cbf05ed386c7 > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > 7f5ed657c30c99d0ee4fec8867b6145c1d26cc24 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java > 131a37533507442f76b1eb2b015f66255e9ea2ac > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java > 254632b6bcf384482365fce19a7c6cfe6b17b974 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogRollupHandler.java > 78e4518b365bb52873cd6a2767e126a8b1d5083b > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7913845caea9f06f0db026ad06855cc87a7617ba > > lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java > decd6ef191be3fbb53839713583037257f738659 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 5e135be0348068125b69016274e00b01140c4f21 > > lens-server/src/test/java/org/apache/lens/server/stats/TestStatisticsLogFileScannerTask.java > bf0526f2d6d71a170a16b767ad7582aa28c9a863 > lens-server/src/test/resources/log4j.properties > 65d065fa699f9797dcb13580359c4d41cfc52e9d > tools/conf-pseudo-distr/server/log4j.properties > afadc2f2856e7723e23265553440984bf2859869 > tools/conf/server/log4j.properties afadc2f2856e7723e23265553440984bf2859869 > > Diff: https://reviews.apache.org/r/34210/diff/ > > > Testing > ------- > > One unit test case is failing. Will update review request again after fixing > the test case and running test suite again. > > > Thanks, > > Himanshu Gahlaut > >
