> On May 22, 2015, 12:26 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/resources/hive-site.xml, line 35 > > <https://reviews.apache.org/r/34535/diff/1/?file=966249#file966249line35> > > > > Can we move this from /tmp to target/ instead, we might have to prepend > > base.dir? > > Raju Bairishetti wrote: > +1. We should use target/ instead of /tmp. > > Many tests(ex: lens cli tests) are using /tmp directory for creating test > files. I think we should create random directories for those tests as well.
It'll not be just about temp directories, it's also becoming about using random, available ports wherever possible. So putting this on hold for a while. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34535/#review84880 ----------------------------------------------------------- On May 21, 2015, 3:24 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34535/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 3:24 p.m.) > > > Review request for lens. > > > Bugs: LENS-571 > https://issues.apache.org/jira/browse/LENS-571 > > > Repository: lens > > > Description > ------- > > add buildnumber and timestamp in hive warehouse > > > Diffs > ----- > > lens-cube/src/test/resources/hive-site.xml > 0bcb2b2a54be97e645422bf4ad3516f97144fa71 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 71fbc7454ad7f20ca674c384723e3e3300cefbc6 > lens-driver-hive/src/test/resources/hive-site.xml > a35dc1178e4382a8e8ea7a2c6ee06dd3ddc4bdbc > lens-driver-hive/src/test/resources/hivedriver-site.xml > 3f37b7a429423ad2d902a4900dd86cc591f9c998 > lens-driver-jdbc/src/test/resources/hive-site.xml > a1dfe5a9e3c5d657940786215684787d4f08b777 > lens-server/pom.xml bb12e006848b291ab9363790868b5e73723841bb > lens-server/src/test/resources/hive-site.xml > 5e694dd20343312afc73102f8ed8d0cf1fca1b43 > lens-server/src/test/resources/hivedriver-site.xml > cd9c655f7a20f9cc9c9c92bd07bb18acb98d867f > lens-storage-db/src/test/resources/hive-site.xml > a1dfe5a9e3c5d657940786215684787d4f08b777 > pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a > > Diff: https://reviews.apache.org/r/34535/diff/ > > > Testing > ------- > > testing by runing parallel builds > > > Thanks, > > Rajat Khandelwal > >
