----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/ -----------------------------------------------------------
(Updated May 28, 2015, 8:44 a.m.) Review request for lens. Changes ------- Implemented review comments. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.790 s] [INFO] Lens ............................................... SUCCESS [ 4.371 s] [INFO] Lens API ........................................... SUCCESS [ 17.194 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 23.262 s] [INFO] Lens Cube .......................................... SUCCESS [03:04 min] [INFO] Lens DB storage .................................... SUCCESS [ 20.814 s] [INFO] Lens Query Library ................................. SUCCESS [ 15.829 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:42 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.726 s] [INFO] Lens Server ........................................ SUCCESS [05:45 min] [INFO] Lens client ........................................ SUCCESS [ 34.110 s] [INFO] Lens CLI ........................................... SUCCESS [02:09 min] [INFO] Lens Examples ...................................... SUCCESS [ 9.406 s] [INFO] Lens Distribution .................................. SUCCESS [ 7.824 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:31 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.484 s] [INFO] Lens Regression .................................... SUCCESS [ 7.528 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:15 min [INFO] Finished at: 2015-05-28T13:45:58+05:30 [INFO] Final Memory: 121M/381M [INFO] ------------------------------------------------------------------------ Repository: lens Description ------- Initial patch for - add jar should be able to take regex path and should be able to add multiple jars. Jira: https://issues.apache.org/jira/browse/LENS-513 Diffs (updated) ----- lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086 lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54 Diff: https://reviews.apache.org/r/34105/diff/ Testing ------- Yes. Testcases: New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex Old testcase modified: TestLensConnectionCliCommands#testJarCommands Test on CLI: 1. -ve test scenario: lens-shell>add jar /home/yash/Desktop/rt.jarr No Jars found in the specified path. lens-shell>add jar /home/yash/Desktop/*.jarr No Jars found in the specified path. 2. +ve test scenario: lens-shell>add jar /home/yash/Desktop/*.jar Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ] lens-shell>list resources type=jar path=/home/yash/Desktop/mahout-core-0.9.jar type=jar path=/home/yash/Desktop/rt.jar Complete build with testcases: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s] [INFO] Lens ............................................... SUCCESS [ 3.751 s] [INFO] Lens API ........................................... SUCCESS [ 19.844 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s] [INFO] Lens Cube .......................................... SUCCESS [03:06 min] [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s] [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s] [INFO] Lens Server ........................................ SUCCESS [06:03 min] [INFO] Lens client ........................................ SUCCESS [ 41.219 s] [INFO] Lens CLI ........................................... SUCCESS [02:09 min] [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s] [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s] [INFO] Lens Regression .................................... SUCCESS [ 8.067 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:46 min [INFO] Finished at: 2015-05-12T19:44:01+05:30 [INFO] Final Memory: 120M/389M [INFO] ------------------------------------------------------------------------ Thanks, Yash Sharma
