-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34797/#review85940
-----------------------------------------------------------



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/34797/#comment137756>

    Everytime you make changes in documentation/arguments in cli, please run 
`org.apache.lens.cli.doc.TestGenerateCLIUserDoc` once. It'll update the docs.



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/34797/#comment137757>

    Please have a look at 
http://docs.spring.io/spring-shell/docs/current/api/org/springframework/shell/core/annotation/CliOption.html
 and decide what should be appropriate values for `specifiedDefaultValue` and 
`unspecifiedDefaultValue`


- Rajat Khandelwal


On May 29, 2015, 10:44 a.m., Pranav Agarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34797/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 10:44 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-590
>     https://issues.apache.org/jira/browse/LENS-590
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> lens-590 Lens CLI "query results" command to support sync option
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 32a89ac98230d642738e1954b965c692c7235507 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> cd8bf166e11786ae8ec26df8d03dd381ef62d787 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 4472a80b9e8b8b7243ec6d15a854867bb24dcce1 
> 
> Diff: https://reviews.apache.org/r/34797/diff/
> 
> 
> Testing
> -------
> 
> tests didn't come out clean yet. Its intermittent and doesn't look to be 
> related to the txn.. 
> I'm running the tests, and in the meanwhile please provide feedback.
> 
> 
> Thanks,
> 
> Pranav Agarwal
> 
>

Reply via email to