> On June 2, 2015, 5:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, > > line 361 > > <https://reviews.apache.org/r/34670/diff/6/?file=975763#file975763line361> > > > > The name here has "total-xxx", but the counter incremented in code does > > not have prefix "total-". > > > > We can define LensServices.SERVER_STATE_PERSISTENCE_ERRORS itself to > > have total- as prefix.
I missed it. Fixed now. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34670/#review86165 ----------------------------------------------------------- On June 2, 2015, 10:05 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34670/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 10:05 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > https://issues.apache.org/jira/browse/LENS-479 > > Note - Did not use AtomicInterger since all the errors are in synchronized > contexts. > > Build results- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.912 > s] > [INFO] Lens ............................................... SUCCESS [ 4.246 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.764 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.822 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:26 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 21.719 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.874 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:38 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.670 > s] > [INFO] Lens Server ........................................ SUCCESS [05:06 > min] > [INFO] Lens client ........................................ SUCCESS [ 37.343 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.199 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.692 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:18 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.651 > s] > [INFO] Lens Regression .................................... SUCCESS [ 8.191 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:42 min > [INFO] Finished at: 2015-05-26T23:03:45+05:30 > [INFO] Final Memory: 120M/388M > [INFO] > ------------------------------------------------------------------------ > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 9cfb65d > lens-server/src/main/java/org/apache/lens/server/LensServices.java ab197ab > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 6e8b3a6 > > Diff: https://reviews.apache.org/r/34670/diff/ > > > Testing > ------- > > New build results- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.235 > s] > [INFO] Lens ............................................... SUCCESS [ 3.278 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.030 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.712 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:10 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.122 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 17.142 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:39 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.479 > s] > [INFO] Lens Server ........................................ SUCCESS [06:22 > min] > [INFO] Lens client ........................................ SUCCESS [ 39.596 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:08 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.293 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 9.541 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:30 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.463 > s] > [INFO] Lens Regression .................................... SUCCESS [ 13.202 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:05 min > [INFO] Finished at: 2015-06-02T15:31:43+05:30 > [INFO] Final Memory: 121M/367M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
