----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34652/ -----------------------------------------------------------
(Updated June 2, 2015, 10:38 a.m.) Review request for lens, Himanshu Gahlaut and Rajat Khandelwal. Repository: lens Description ------- https://issues.apache.org/jira/browse/LENS-478 Was not sure which all scenarios are counted as failure conditions so posting an initai review request. Not included 'Invalid Dir' and 'no .jar files' as error conditions. Also removed unwanted throw clauses. Please review. Diffs ----- lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 9cfb65d lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 6e8b3a6 lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 608c679 Diff: https://reviews.apache.org/r/34652/diff/ Testing (updated) ------- New build results- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.786 s] [INFO] Lens ............................................... SUCCESS [ 3.960 s] [INFO] Lens API ........................................... SUCCESS [ 18.098 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 21.742 s] [INFO] Lens Cube .......................................... SUCCESS [03:10 min] [INFO] Lens DB storage .................................... SUCCESS [ 19.967 s] [INFO] Lens Query Library ................................. SUCCESS [ 16.824 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:40 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.233 s] [INFO] Lens Server ........................................ SUCCESS [05:56 min] [INFO] Lens client ........................................ SUCCESS [ 38.323 s] [INFO] Lens CLI ........................................... SUCCESS [02:07 min] [INFO] Lens Examples ...................................... SUCCESS [ 10.348 s] [INFO] Lens Distribution .................................. SUCCESS [ 8.957 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:30 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s] [INFO] Lens Regression .................................... SUCCESS [ 11.838 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:37 min [INFO] Finished at: 2015-06-02T16:03:09+05:30 [INFO] Final Memory: 120M/402M [INFO] ------------------------------------------------------------------------ [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.086 s] [INFO] Lens ............................................... SUCCESS [ 3.403 s] [INFO] Lens API ........................................... SUCCESS [ 17.744 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 22.806 s] [INFO] Lens Cube .......................................... SUCCESS [02:53 min] [INFO] Lens DB storage .................................... SUCCESS [ 19.335 s] [INFO] Lens Query Library ................................. SUCCESS [ 18.111 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:37 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.961 s] [INFO] Lens Server ........................................ SUCCESS [04:40 min] [INFO] Lens client ........................................ SUCCESS [ 35.310 s] [INFO] Lens CLI ........................................... SUCCESS [01:53 min] [INFO] Lens Examples ...................................... SUCCESS [ 9.024 s] [INFO] Lens Distribution .................................. SUCCESS [ 7.767 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:12 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.749 s] [INFO] Lens Regression .................................... SUCCESS [ 6.677 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 16:16 min [INFO] Finished at: 2015-05-25T21:16:48+05:30 [INFO] Final Memory: 121M/377M [INFO] ------------------------------------------------------------------------ Thanks, Yash Sharma
