> On June 2, 2015, 10:38 a.m., Amareshwari Sriramadasu wrote: > > - Can you include unit tests? > > - Did not see any changes wrt dynamic queue name in the loader? Are you > > planning include those changes in a follow up patch ? > > Rajat Khandelwal wrote: > dynamic queue name is not generic enough to be included in lens. Lens as > a platform should be satisfied with providing a hook for users to use. That > hook can be used for any conf changes, including dynamic queues.
I have two approaches in mind: 1. Don't change driver api, inside driver's executeAsync, driver should call preSubmit. Any new driver can choose not to call preSubmit in this case. 2. Change driver's api so that preSubmit is called from the execution service. This might break backward compatibility. I saw in the code that Approach 1 is taken for registering driver event handlers. That's why I too went ahead with approach 1. Would love other opinions. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34876/#review86160 ----------------------------------------------------------- On June 1, 2015, 6:38 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34876/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 6:38 p.m.) > > > Review request for lens. > > > Bugs: LENS-555 > https://issues.apache.org/jira/browse/LENS-555 > > > Repository: lens > > > Description > ------- > > Right now the hadoop queue where the hive job is triggered is fixed. This > needs to be dynamic. We have one requirement where our yarn cluster has > hierarchical queues based on job priority. We need capability to be able to > choose the right queue based on priority of the job > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 052d0e2bd0584e65dd06c0241dcf99dc1773045b > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 70deaa401fa5168ad7780804ef68cca8a2660eae > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 8511ce63b3845973d7532ffa15c7158e69726716 > > lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoaderException.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > dbc52e9fcda9bb897264c1e357a679454ef1983f > > lens-server/src/main/java/org/apache/lens/server/user/CustomUserConfigLoader.java > 9a6a350a2808bb844ef870089fccf20a2136de72 > > lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java > d2679488aeb2b91105f087e34143bc848f1f3d52 > > lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java > b81b994ad00d09f5a0b9dd44cbdf731da3b2d0e6 > > lens-server/src/main/java/org/apache/lens/server/user/LDAPBackedDatabaseUserConfigLoader.java > 108a0123a78736892a3adb8bb24ff401e5a81b4e > > lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java > 16a9a709d097c8af8a84ea81282d0d43947fcd3d > lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoader.java > 21eea3bdbd5a84770e6144d1ed45806ad4dc6ee3 > > lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderException.java > 0899746f8350b4b84c1e03c3f262f553faef9817 > > lens-server/src/main/java/org/apache/lens/server/user/UserConfigLoaderFactory.java > 383aaf5f0d5a3937b95b0077491d30678ffe46a3 > > Diff: https://reviews.apache.org/r/34876/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.690s] > [INFO] Lens .............................................. SUCCESS [2.921s] > [INFO] Lens API .......................................... SUCCESS [18.691s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.498s] > [INFO] Lens Cube ......................................... SUCCESS [3:34.121s] > [INFO] Lens DB storage ................................... SUCCESS [21.515s] > [INFO] Lens Query Library ................................ SUCCESS [17.675s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:54.117s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.549s] > [INFO] Lens Server ....................................... SUCCESS [5:25.651s] > [INFO] Lens client ....................................... SUCCESS [36.611s] > [INFO] Lens CLI .......................................... SUCCESS [3:21.647s] > [INFO] Lens Examples ..................................... SUCCESS [9.916s] > [INFO] Lens Distribution ................................. SUCCESS [7.971s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.772s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.261s] > [INFO] Lens Regression ................................... SUCCESS [8.378s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:44.006s > [INFO] Finished at: Mon Jun 01 11:12:36 UTC 2015 > [INFO] Final Memory: 162M/1110M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
