----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34991/#review86554 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java <https://reviews.apache.org/r/34991/#comment138615> Is this special handling needed? I think the `findCoveringSets` will take care of this. - Rajat Khandelwal On June 3, 2015, 3:02 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34991/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 3:02 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-174 > https://issues.apache.org/jira/browse/LENS-174 > > > Repository: lens > > > Description > ------- > > Changes include : > - Fix the query with no measures queried and only expression measures queried. > - Fix the query measures and no expression measures queried > - Incorporated review comments from https://reviews.apache.org/r/34399/ > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 2ad2b7c > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > 4d3443c > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > d56fb80 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 0409af3 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > f2a7039 > > Diff: https://reviews.apache.org/r/34991/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s] > [INFO] Lens .............................................. SUCCESS [2.813s] > [INFO] Lens API .......................................... SUCCESS [20.301s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.134s] > [INFO] Lens Cube ......................................... SUCCESS [3:57.179s] > [INFO] Lens DB storage ................................... SUCCESS [20.292s] > [INFO] Lens Query Library ................................ SUCCESS [14.633s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s] > [INFO] Lens Server ....................................... SUCCESS [5:15.330s] > [INFO] Lens client ....................................... SUCCESS [36.762s] > [INFO] Lens CLI .......................................... SUCCESS [3:21.390s] > [INFO] Lens Examples ..................................... SUCCESS [10.458s] > [INFO] Lens Distribution ................................. SUCCESS [8.112s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s] > [INFO] Lens Regression ................................... SUCCESS [15.137s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:01.492s > [INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015 > [INFO] Final Memory: 160M/959M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
