----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/ -----------------------------------------------------------
(Updated June 6, 2015, 7:18 a.m.) Review request for lens. Changes ------- Implemented new review comments. Build results- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.234 s] [INFO] Lens ............................................... SUCCESS [ 3.300 s] [INFO] Lens API ........................................... SUCCESS [ 18.254 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 20.630 s] [INFO] Lens Cube .......................................... SUCCESS [03:05 min] [INFO] Lens DB storage .................................... SUCCESS [ 19.407 s] [INFO] Lens Query Library ................................. SUCCESS [ 15.674 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:35 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.225 s] [INFO] Lens Server ........................................ SUCCESS [04:49 min] [INFO] Lens client ........................................ SUCCESS [ 36.588 s] [INFO] Lens CLI ........................................... SUCCESS [02:06 min] [INFO] Lens Examples ...................................... SUCCESS [ 10.305 s] [INFO] Lens Distribution .................................. SUCCESS [ 9.286 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:14 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.495 s] [INFO] Lens Regression .................................... SUCCESS [ 12.271 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 16:57 min [INFO] Finished at: 2015-06-06T12:27:21+05:30 [INFO] Final Memory: 121M/393M [INFO] ------------------------------------------------------------------------ Repository: lens Description ------- Initial patch for - add jar should be able to take regex path and should be able to add multiple jars. Jira: https://issues.apache.org/jira/browse/LENS-513 Diffs (updated) ----- lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086 lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54 lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION Diff: https://reviews.apache.org/r/34105/diff/ Testing ------- New build results - [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s] [INFO] Lens ............................................... SUCCESS [ 3.057 s] [INFO] Lens API ........................................... SUCCESS [ 17.761 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s] [INFO] Lens Cube .......................................... SUCCESS [03:20 min] [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s] [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s] [INFO] Lens Server ........................................ SUCCESS [06:20 min] [INFO] Lens client ........................................ SUCCESS [ 36.356 s] [INFO] Lens CLI ........................................... SUCCESS [02:04 min] [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s] [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s] [INFO] Lens Regression .................................... SUCCESS [ 6.617 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 19:01 min [INFO] Finished at: 2015-06-02T14:11:56+05:30 [INFO] Final Memory: 120M/389M [INFO] ------------------------------------------------------------------------ Yes. Testcases: New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex Old testcase modified: TestLensConnectionCliCommands#testJarCommands Test on CLI: 1. -ve test scenario: lens-shell>add jar /home/yash/Desktop/rt.jarr No Jars found in the specified path. lens-shell>add jar /home/yash/Desktop/*.jarr No Jars found in the specified path. 2. +ve test scenario: lens-shell>add jar /home/yash/Desktop/*.jar Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ] lens-shell>list resources type=jar path=/home/yash/Desktop/mahout-core-0.9.jar type=jar path=/home/yash/Desktop/rt.jar Complete build with testcases: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s] [INFO] Lens ............................................... SUCCESS [ 3.751 s] [INFO] Lens API ........................................... SUCCESS [ 19.844 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s] [INFO] Lens Cube .......................................... SUCCESS [03:06 min] [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s] [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s] [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s] [INFO] Lens Server ........................................ SUCCESS [06:03 min] [INFO] Lens client ........................................ SUCCESS [ 41.219 s] [INFO] Lens CLI ........................................... SUCCESS [02:09 min] [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s] [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s] [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s] [INFO] Lens Regression .................................... SUCCESS [ 8.067 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 18:46 min [INFO] Finished at: 2015-05-12T19:44:01+05:30 [INFO] Final Memory: 120M/389M [INFO] ------------------------------------------------------------------------ Thanks, Yash Sharma
