-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35055/#review87127
-----------------------------------------------------------
Can we change isJoinKey to true in ReferencedDimAtrribute as well?
```
public ReferencedDimAtrribute(String name, Map<String, String> props) {
super(name, props);
String chName = props.get(MetastoreUtil.getDimRefChainNameKey(getName()));
if (!StringUtils.isBlank(chName)) {
this.chainName = chName;
this.refColumn =
props.get(MetastoreUtil.getDimRefChainColumnKey(getName()));
this.isJoinKey = false;
} else {
```
```
public ReferencedDimAtrribute(FieldSchema column, String displayString, String
chainName, String refColumn,
Date startTime, Date endTime, Double cost, Long numOfDistinctValues) {
super(column, displayString, startTime, endTime, cost, numOfDistinctValues);
this.chainName = chainName.toLowerCase();
this.refColumn = refColumn.toLowerCase();
this.isJoinKey = false;
}
```
- Raju Bairishetti
On June 4, 2015, 9:23 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35055/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 9:23 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-575
> https://issues.apache.org/jira/browse/LENS-575
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added testcase which reproduced the NPE and put up fix as well.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 719d10d
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
> d56fb80
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
> 914fe1b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
> d121ba4
>
> Diff: https://reviews.apache.org/r/35055/diff/
>
>
> Testing
> -------
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.536s]
> [INFO] Lens .............................................. SUCCESS [3.011s]
> [INFO] Lens API .......................................... SUCCESS [17.777s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.173s]
> [INFO] Lens Cube ......................................... SUCCESS [3:33.834s]
> [INFO] Lens DB storage ................................... SUCCESS [20.476s]
> [INFO] Lens Query Library ................................ SUCCESS [17.480s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.128s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.125s]
> [INFO] Lens Server ....................................... SUCCESS [5:39.016s]
> [INFO] Lens client ....................................... SUCCESS [36.548s]
> [INFO] Lens CLI .......................................... SUCCESS [3:30.731s]
> [INFO] Lens Examples ..................................... SUCCESS [10.937s]
> [INFO] Lens Distribution ................................. SUCCESS [8.005s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.748s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.819s]
> [INFO] Lens Regression ................................... SUCCESS [12.212s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 20:07.530s
> [INFO] Finished at: Thu Jun 04 09:16:15 UTC 2015
> [INFO] Final Memory: 159M/1063M
> [INFO]
> ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
