> On June 9, 2015, 11:47 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java, > > line 418 > > <https://reviews.apache.org/r/35248/diff/1/?file=981350#file981350line418> > > > > What was the output before the fix?
aggrexpr is not considered aggregate. So, no groupby clause comes. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35248/#review87161 ----------------------------------------------------------- On June 9, 2015, 10:51 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35248/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 10:51 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-596 > https://issues.apache.org/jira/browse/LENS-596 > > > Repository: lens > > > Description > ------- > > Includes the fix and test cases which fail with out fix. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 539badb > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 6a2a897 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 914fe1b > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 5cb7b0a > > Diff: https://reviews.apache.org/r/35248/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.291s] > [INFO] Lens .............................................. SUCCESS [3.321s] > [INFO] Lens API .......................................... SUCCESS [19.004s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.481s] > [INFO] Lens Cube ......................................... SUCCESS [3:37.559s] > [INFO] Lens DB storage ................................... SUCCESS [19.081s] > [INFO] Lens Query Library ................................ SUCCESS [14.461s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:53.516s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [33.314s] > [INFO] Lens Server ....................................... SUCCESS [5:31.320s] > [INFO] Lens client ....................................... SUCCESS [36.621s] > [INFO] Lens CLI .......................................... SUCCESS [3:32.652s] > [INFO] Lens Examples ..................................... SUCCESS [9.113s] > [INFO] Lens Distribution ................................. SUCCESS [8.209s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.289s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.043s] > [INFO] Lens Regression ................................... SUCCESS [10.351s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:54.531s > [INFO] Finished at: Tue Jun 09 10:47:51 UTC 2015 > [INFO] Final Memory: 168M/1229M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
