> On June 9, 2015, 6:51 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java, > > line 184 > > <https://reviews.apache.org/r/35063/diff/2/?file=979770#file979770line184> > > > > Test case for the change?
Current tests cover this. Here are all the facts in testCube and their weights: cheapFact : 0 testFact : 5L testFactWeekly : 5L testFactMonthly : 5L testFact2 : 10L summary1 : 10L summary2 : 20L summary3 : 30L testFact2_raw : 100L Choosing among equal weighted facts results in picking facts with least time rollups - because of LeastPartitionResolver. For ex: testFactMonthly vs testFact for month range query. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35063/#review87144 ----------------------------------------------------------- On June 5, 2015, 9:03 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35063/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 9:03 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-414 > https://issues.apache.org/jira/browse/LENS-414 > > > Repository: lens > > > Description > ------- > > Moved LightestFactResolver before LeastPartitionResolver - that says "if two > facts have the same least weight, then the fact with least number of time > partitions queried will be picked". This will be useful, if users did not set > fact weights. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 57c91e7 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > d0b3ccb > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > 39f70eb > > Diff: https://reviews.apache.org/r/35063/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.443s] > [INFO] Lens .............................................. SUCCESS [3.144s] > [INFO] Lens API .......................................... SUCCESS [19.933s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.866s] > [INFO] Lens Cube ......................................... SUCCESS [3:30.712s] > [INFO] Lens DB storage ................................... SUCCESS [20.469s] > [INFO] Lens Query Library ................................ SUCCESS [16.834s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:54.473s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.130s] > [INFO] Lens Server ....................................... SUCCESS [5:42.657s] > [INFO] Lens client ....................................... SUCCESS [37.203s] > [INFO] Lens CLI .......................................... SUCCESS [4:10.969s] > [INFO] Lens Examples ..................................... SUCCESS [12.813s] > [INFO] Lens Distribution ................................. SUCCESS [8.697s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:36.895s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.316s] > [INFO] Lens Regression ................................... SUCCESS [17.742s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:17.254s > [INFO] Finished at: Thu Jun 04 11:04:13 UTC 2015 > [INFO] Final Memory: 162M/1092M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
