----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35458/#review88215 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java (line 163) <https://reviews.apache.org/r/35458/#comment140618> This should not be a class level variable. Should be simply method level. - Amareshwari Sriramadasu On June 17, 2015, 8:29 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35458/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 8:29 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-603 > https://issues.apache.org/jira/browse/LENS-603 > > > Repository: lens > > > Description > ------- > > Check if projected column is expression and skip rewrite. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 9ba136f > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > aab7f31 > > Diff: https://reviews.apache.org/r/35458/diff/ > > > Testing > ------- > > Added unit test. mvn clean test is running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [10.186s] > [INFO] Lens .............................................. SUCCESS [0.331s] > [INFO] Lens API .......................................... SUCCESS [19.852s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.933s] > [INFO] Lens Cube ......................................... SUCCESS [4:27.262s] > [INFO] Lens DB storage ................................... SUCCESS [16.455s] > [INFO] Lens Query Library ................................ SUCCESS [8.453s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:28.647s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.158s] > [INFO] Lens Server ....................................... SUCCESS > [24:30.006s] > [INFO] Lens client ....................................... SUCCESS [49.657s] > [INFO] Lens CLI .......................................... SUCCESS [6:44.758s] > [INFO] Lens Examples ..................................... SUCCESS [5.254s] > [INFO] Lens Distribution ................................. SUCCESS [2.389s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:44.468s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [9.835s] > [INFO] Lens Regression ................................... SUCCESS [3.138s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 44:56.265s > [INFO] Finished at: Mon Jun 15 16:33:00 IST 2015 > [INFO] Final Memory: 146M/1433M > > > Thanks, > > Sushil Mohanty > >
