> On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, > > line 388 > > <https://reviews.apache.org/r/35459/diff/1/?file=984670#file984670line388> > > > > I think we don't need to pass `(String[])null`, varargs takes care of > > that automatically.
It was giving warning in my IDE. > On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java, > > line 98 > > <https://reviews.apache.org/r/35459/diff/1/?file=984672#file984672line98> > > > > The new function can be used? No. New function call is only for joinchains. > On June 18, 2015, 6:52 a.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java, > > line 169 > > <https://reviews.apache.org/r/35459/diff/1/?file=984674#file984674line169> > > > > Is this change related? Yes. Now we are adding the queried, instead of source columns. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35459/#review88344 ----------------------------------------------------------- On June 16, 2015, 7:15 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35459/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 7:15 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-605 > https://issues.apache.org/jira/browse/LENS-605 > > > Repository: lens > > > Description > ------- > > Fixes Candidate pruning wrt sourcecolumns required for joinchains > > - Fixes when multiple tables not reachable for a candidate. Added regression > tests > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 79d6d43 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c5d8d91 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 1a7b6b4 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 8e199ea > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > a760599 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > e615ccc > > Diff: https://reviews.apache.org/r/35459/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [6.972s] > [INFO] Lens .............................................. SUCCESS [10.815s] > [INFO] Lens API .......................................... SUCCESS [42.589s] > [INFO] Lens API for server and extensions ................ SUCCESS [29.129s] > [INFO] Lens Cube ......................................... SUCCESS [5:44.521s] > [INFO] Lens DB storage ................................... SUCCESS [39.222s] > [INFO] Lens Query Library ................................ SUCCESS [24.951s] > [INFO] Lens Hive Driver .................................. SUCCESS [4:46.073s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [52.714s] > [INFO] Lens Server ....................................... SUCCESS > [36:12.315s] > [INFO] Lens client ....................................... SUCCESS [2:07.156s] > [INFO] Lens CLI .......................................... SUCCESS > [13:16.990s] > [INFO] Lens Examples ..................................... SUCCESS [22.787s] > [INFO] Lens Distribution ................................. SUCCESS [38.863s] > [INFO] Lens ML Lib ....................................... SUCCESS [5:37.658s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [28.590s] > [INFO] Lens Regression ................................... SUCCESS [25.328s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:13:07.899s > [INFO] Finished at: Tue Jun 16 12:43:29 IST 2015 > [INFO] Final Memory: 124M/502M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
