> On June 22, 2015, 6:20 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, > > line 95 > > <https://reviews.apache.org/r/35589/diff/2/?file=989047#file989047line95> > > > > Don't need to have return values for functions `removeDirs`, > > `filterByJarType`. They are taking a collection and modifying itself.
Earlier removeDirs was working on an unmodifiable list so was returning a new copy of the filtered list. Now have merged both and removed dependency on unmodifiable list. No return values now. > On June 22, 2015, 6:20 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, > > line 46 > > <https://reviews.apache.org/r/35589/diff/2/?file=989047#file989047line46> > > > > parent_dir > > | > > |__ a_dir > > | | > > | |__ jar_1 > > | | > > | |__ jar_2 > > | | > > | |__ jar_order(*1\n*2) > > | > > |__ b_dir > > | | > > | |__ jar_3 > > | | > > | |__ jar_4 > > | | > > | |__ glob_order(*4\n*3) > > | > > |__ c_dir > > | | > > | |__ jar_5 > > | | > > | |__ jar_6 > > | > > |__ jar_order(a*\nb*\nc*) > > > > > > new ScannedPaths("parent_*") > > > > > > > > Will this work? > > Rajat Khandelwal wrote: > parent_dir > | > |__ a_dir > | | > | |__ jar_1 > | | > | |__ jar_2 > | | > | |__ jar_order(*1\n*2) > | > |__ b_dir > | | > | |__ jar_3 > | | > | |__ jar_4 > | | > | |__ glob_order(*4\n*3) > | > |__ c_dir > | | > | |__ jar_5 > | | > | |__ jar_6 > | > |__ jar_order(a*\nb*\nc*) > > > new ScannedPaths("parent_*") > > > (markdown causing problems) Added new testcase for checcking coverage of the scenario. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88735 ----------------------------------------------------------- On June 22, 2015, 11:31 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 11:31 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
