> On June 22, 2015, 1:11 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 150 > > <https://reviews.apache.org/r/35589/diff/4/?file=989676#file989676line150> > > > > This check is not needed. Can be covered by Line 165. Similar for > > delete.
Removed! > On June 22, 2015, 1:11 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 155 > > <https://reviews.apache.org/r/35589/diff/4/?file=989676#file989676line155> > > > > instead of obtaining `iterator()` beforehand, we can only obtain a > > `ScannedPaths` object and then use foreach loop here. Implemented. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35589/#review88777 ----------------------------------------------------------- On June 22, 2015, 1:37 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35589/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 1:37 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Add jar should be able to take regex path and should be able to add multiple > jars. > > https://issues.apache.org/jira/browse/LENS-513 > > New review comments for reopened jira. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 4d82a06 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > ac773fe > lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java > 5073634 > > Diff: https://reviews.apache.org/r/35589/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
