----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36188/#review90441 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On July 5, 2015, 7:15 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36188/ > ----------------------------------------------------------- > > (Updated July 5, 2015, 7:15 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > https://issues.apache.org/jira/browse/LENS-574 > > mvn test -Dtest=TestLensDAO#testLensServerDAO > > Running org.apache.lens.server.query.TestLensDAO > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.165 sec > <<< FAILURE! - in org.apache.lens.server.query.TestLensDAO > testLensServerDAO(org.apache.lens.server.query.TestLensDAO) Time elapsed: > 0.044 sec <<< FAILURE! > org.apache.lens.server.api.error.LensException: null > at org.hsqldb.jdbc.Util.notSupported(Unknown Source) > at org.hsqldb.jdbc.JDBCResultSet.checkNotForwardOnly(Unknown Source) > at org.hsqldb.jdbc.JDBCResultSet.beforeFirst(Unknown Source) > at > org.apache.commons.dbcp.DelegatingResultSet.beforeFirst(DelegatingResultSet.java:358) > at > org.apache.commons.dbcp.DelegatingResultSet.beforeFirst(DelegatingResultSet.java:358) > at > org.apache.lens.driver.jdbc.JDBCResultSet.seekToStart(JDBCResultSet.java:302) > at > org.apache.lens.driver.jdbc.JDBCResultSet.<init>(JDBCResultSet.java:83) > at > org.apache.lens.server.query.TestLensDAO.testLensServerDAO(TestLensDAO.java:82) > > > Rootcause: > HSQLDB's result set object is ResultSet.TYPE_FORWARD_ONLY by default- > therefore it blows up in checkNotForwardOnly. > Minor Fix: > createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, > ResultSet.CONCUR_READ_ONLY); > > > Diffs > ----- > > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 36f9d77 > > Diff: https://reviews.apache.org/r/36188/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
