-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36016/#review90867
-----------------------------------------------------------


committed to LENS-581 branch. Vikas - Please mark the review comments resolved 
which have been taken care.

- sharad agarwal


On July 8, 2015, 4:32 a.m., vikas singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36016/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 4:32 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Pranav 
> Agarwal, and sharad agarwal.
> 
> 
> Bugs: LENS-581
>     https://issues.apache.org/jira/browse/LENS-581
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Implementation for new Lens ML API. This is not a complete implementation. 
> Model creation, traning into modelInstances. evaluations and prediction is 
> implemented.
> Each of the modelInstance, prediciton and evaluation is creation in an async 
> manner. Metastore and Web API is not implemented. Testing of the code is done.
> 
> 
> Diffs
> -----
> 
>   lens-ml-lib/data/lr/lr_train.data PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/client/LensMLClient.java 6dd0ecf 
>   lens-ml-lib/src/main/java/org/apache/lens/client/LensMLJerseyClient.java 
> c68dd12 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/AlgoParam.java 
> e0d13c0 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/Algorithm.java 
> 29bde29 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLAlgo.java 65373c6 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLDriver.java d2a2748 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLModel.java 73717ac 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/TrainedModel.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/AlgoArgParser.java 
> 00f20fc 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/Algorithms.java 
> ad37403 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/ClassifierBaseModel.java
>  a960a4a 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/lib/ForecastingModel.java 
> 16a6180 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkAlgo.java 
> 86cab38 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/BaseSparkClassificationModel.java
>  806dc1f 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/ColumnFeatureFunction.java
>  d75efc0 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/HiveTableRDD.java 
> 4960e1e 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/SparkMLDriver.java 
> 21ed87d 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/TableTrainingSpec.java
>  897aacb 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/dt/DecisionTreeAlgo.java
>  7810a9a 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/dt/DecisionTreeClassificationModel.java
>  27c32f4 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/dt/SparkDecisionTreeModel.java
>  e561a8d 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/kmeans/KMeansAlgo.java
>  be9af18 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/kmeans/KMeansClusteringModel.java
>  62dc536 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/lr/LogisticRegressionAlgo.java
>  c2f97af 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/lr/LogitRegressionClassificationModel.java
>  a4206e5 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/nb/NaiveBayesAlgo.java
>  c484dfe 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/nb/NaiveBayesClassificationModel.java
>  26d39df 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/svm/SVMAlgo.java 
> 4b14d66 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/spark/svm/SVMClassificationModel.java
>  433c0f9 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Algo.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/AlgoParam.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/AlgoSpec.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/DataSet.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Evaluation.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Feature.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/LensML.java 23b5437 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/MLConfConstants.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/MLProcess.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/MLTestReport.java 965161a 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Model.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/ModelInstance.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/ModelMetadata.java 3f7dff1 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Prediction.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/Status.java PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/api/TestReport.java 294fef3 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/dao/InMemoryMetaStoreClient.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/dao/MLDBUtils.java d444a32 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/dao/MetaStoreClient.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/BatchPredictSpec.java 
> PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/HiveMLUDF.java 60a4008 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 5938f8a 
>   
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLProcessLifeCycleManager.java
>  PRE-CREATION 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLRunner.java e5ec272 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLTask.java 2867b90 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/MLUtils.java 9c96d9b 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/ModelLoader.java c0e7953 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/QueryRunner.java 2eeee29 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/impl/TableTestingSpec.java 
> 34b2a3f 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLApp.java e6e3c02 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java 
> de9c711 
>   lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 
> 77a6c40 
>   lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fc4164f 
>   lens-ml-lib/src/test/java/org/apache/lens/ml/ExampleUtils.java 9fe1ea0 
>   lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java 51344ce 
>   lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 7f6413b 
>   lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLServices.java 
> PRE-CREATION 
>   lens-ml-lib/src/test/resources/lens-site.xml 3d5dbef 
>   lens-ml-lib/src/test/resources/log4j.properties PRE-CREATION 
>   src/site/apt/user/cli.apt 353c171 
> 
> Diff: https://reviews.apache.org/r/36016/diff/
> 
> 
> Testing
> -------
> 
> yes.
> 
> 
> Thanks,
> 
> vikas singh
> 
>

Reply via email to